Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add state comments #487

Merged
merged 3 commits into from
Apr 19, 2022
Merged

chore: add state comments #487

merged 3 commits into from
Apr 19, 2022

Conversation

GimmeCyy
Copy link
Contributor

@GimmeCyy GimmeCyy commented Apr 19, 2022

What this PR does:
add state anno #438

@mosn-community-bot
Copy link

Hi @GimmeCyy, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@42bd651). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 05eb1a6 differs from pull request most recent head c23c9ba. Consider uploading reports for the commit c23c9ba to get more accurate results

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage        ?   60.50%           
=======================================
  Files           ?      118           
  Lines           ?     6357           
  Branches        ?        0           
=======================================
  Hits            ?     3846           
  Misses          ?     2142           
  Partials        ?      369           
Impacted Files Coverage Δ
pkg/grpc/dapr/dapr_api_state.go 21.84% <ø> (ø)
pkg/grpc/default_api/api_state.go 86.48% <ø> (ø)
pkg/runtime/state/compatibility.go 100.00% <ø> (ø)
pkg/runtime/state/factory.go 100.00% <ø> (ø)
pkg/runtime/state/registry.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bd651...c23c9ba. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood changed the title feature:add state anno feature: add state anno Apr 19, 2022
@seeflood
Copy link
Member

Thanks for your contribution and welcome to the community !

@seeflood seeflood merged commit f46cc1f into mosn:main Apr 19, 2022
@seeflood seeflood changed the title feature: add state anno chore: add state comments Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants