feat: upgrade assemblyscript faas demo(#256) #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zu1k
suggested changes
Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 60.58% 60.58%
=======================================
Files 119 119
Lines 6378 6378
=======================================
Hits 3864 3864
Misses 2144 2144
Partials 370 370 Continue to review full report at Codecov.
|
|
I'm not familiar with assemblyscript, but LGTM. |
zu1k
approved these changes
Apr 20, 2022
|
Thanks for your contribution! We can merge this PR and #475 after v0.4 released |
zhenjunMa
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrade the wasm demo developed by AssemblyScript(#256)
Special notes for your reviewer:
The Node.js version should >=16.14.0