Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Upgrade the wasm demo developed by rust(#255) #475

Merged
merged 6 commits into from
Apr 22, 2022
Merged

feature: Upgrade the wasm demo developed by rust(#255) #475

merged 6 commits into from
Apr 22, 2022

Conversation

nanjingboy
Copy link
Contributor

What this PR does:

Upgrade the wasm demo developed by rust(#255)

Special notes for your reviewer:

the Rust version should not less than 1.56.0.

@mosn-community-bot
Copy link

Hi @nanjingboy, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@nanjingboy
Copy link
Contributor Author

@seeflood

@nanjingboy nanjingboy changed the title Upgrade the wasm demo developed by rust(#255) feature: Upgrade the wasm demo developed by rust(#255) Apr 14, 2022
@seeflood
Copy link
Member

Thanks for your contribution!
Please sign the cla first

@nanjingboy
Copy link
Contributor Author

Thanks for your contribution! Please sign the cla first

already signed

@seeflood
Copy link
Member

@zhenjunMa @zu1k Please help review this PR, thx

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #475 (ae95659) into main (78a4d88) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   60.58%   60.58%           
=======================================
  Files         119      119           
  Lines        6378     6378           
=======================================
  Hits         3864     3864           
  Misses       2144     2144           
  Partials      370      370           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a4d88...ae95659. Read the comment docs.

@zu1k zu1k self-requested a review April 14, 2022 07:48
@zu1k
Copy link
Member

zu1k commented Apr 14, 2022

LGTM

@nanjingboy
Copy link
Contributor Author

nanjingboy commented Apr 21, 2022

@seeflood the review is blocked

@seeflood
Copy link
Member

@seeflood the review is blocked

Waiting for @zhenjunMa 's review

@nanjingboy Besides, since we are going to release v0.4, this PR will be merged after v0.4 released

@seeflood seeflood added this to the v0.5 milestone Apr 21, 2022
Copy link
Contributor

@zhenjunMa zhenjunMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for this contribution, I've always wanted to do this, but I haven't had time. 😏

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit cd96c75 into mosn:main Apr 22, 2022
@nanjingboy nanjingboy deleted the feat/wasm-rust-demo branch April 23, 2022 14:36
@zhenjunMa zhenjunMa linked an issue May 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the wasm demo developed by rust
4 participants