-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Upgrade the wasm demo developed by rust(#255) #475
Conversation
Hi @nanjingboy, welcome to mosn community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Thanks for your contribution! |
already signed |
@zhenjunMa @zu1k Please help review this PR, thx |
Codecov Report
@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 60.58% 60.58%
=======================================
Files 119 119
Lines 6378 6378
=======================================
Hits 3864 3864
Misses 2144 2144
Partials 370 370 Continue to review full report at Codecov.
|
LGTM |
@seeflood the review is blocked |
Waiting for @zhenjunMa 's review @nanjingboy Besides, since we are going to release v0.4, this PR will be merged after v0.4 released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for this contribution, I've always wanted to do this, but I haven't had time. 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does:
Upgrade the wasm demo developed by rust(#255)
Special notes for your reviewer:
the Rust version should not less than 1.56.0.