Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete layotto's dependency on go-sdk #461

Merged
merged 10 commits into from
May 19, 2022
Merged

Conversation

zhenjunMa
Copy link
Contributor

What this PR does:

delete go-sdk dependency in main go.mod

Which issue(s) this PR fixes:

Fixes #452

@zhenjunMa zhenjunMa changed the title refactor runtime integrate test fix: refactor runtime integrate test Apr 11, 2022
@mosn-community-bot mosn-community-bot bot added the bug Something isn't working label Apr 11, 2022
@zhenjunMa zhenjunMa closed this Apr 11, 2022
@zhenjunMa zhenjunMa reopened this Apr 11, 2022
@seeflood seeflood mentioned this pull request May 4, 2022
25 tasks
@seeflood
Copy link
Member

seeflood commented May 5, 2022

@zhenjunMa Time to continue with this PR :)

@seeflood seeflood changed the title fix: refactor runtime integrate test fix: delete layotto's dependency on go-sdk May 13, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #461 (5bc5fb2) into main (5db44ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3874     3874           
  Misses       2139     2139           
  Partials      369      369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db44ed...5bc5fb2. Read the comment docs.

@seeflood seeflood requested a review from Xunzhuo May 19, 2022 12:11
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @zhenjunMa

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit e1a0b55 into mosn:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layotto shouldn't require go-sdk in the go.mod
3 participants