Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize dockerfiles and makefiles #408

Merged
merged 5 commits into from
Mar 29, 2022
Merged

chore: optimize dockerfiles and makefiles #408

merged 5 commits into from
Mar 29, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Mar 10, 2022

Signed-off-by: Xunzhuo [email protected]

What this PR does:

  1. remove some unused/duplicated commands/dockerfile
  2. remove unnecessary docker build to optimize speed
  3. add tag variable to make image to release CI
  4. add default dev image tag like dev-${MAJOR_VERSION}-${GIT_VERSION}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #408 (287a19b) into main (5fd23de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         117      117           
  Lines        6252     6252           
=======================================
  Hits         3763     3763           
  Misses       2128     2128           
  Partials      361      361           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd23de...287a19b. Read the comment docs.

@Xunzhuo Xunzhuo changed the title chore: remove unused dockerfile chore: optimize dockerfiles and makefiles Mar 10, 2022
@Xunzhuo Xunzhuo closed this Mar 10, 2022
@Xunzhuo Xunzhuo reopened this Mar 10, 2022
@Xunzhuo Xunzhuo requested a review from seeflood March 11, 2022 03:32
@seeflood
Copy link
Member

@stulzq @ZLBer @wenxuwan @MoonShining @zhenjunMa @MentosL Hi all,could u help review this PR?

Makefile Show resolved Hide resolved
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenjunMa zhenjunMa merged commit 9fe06ce into mosn:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants