Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file qiniu cloud oss #401

Merged
merged 13 commits into from
Mar 11, 2022
Merged

Conversation

stulzq
Copy link
Member

@stulzq stulzq commented Mar 1, 2022

What this PR does:
Add file qiniu cloud oss
Which issue(s) this PR fixes:

None
Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #401 (2d9939c) into main (8abb21d) will increase coverage by 1.06%.
The diff coverage is 100.00%.

❗ Current head 2d9939c differs from pull request most recent head 6331c1d. Consider uploading reports for the commit 6331c1d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   58.64%   59.70%   +1.06%     
==========================================
  Files         113      115       +2     
  Lines        6018     6177     +159     
==========================================
+ Hits         3529     3688     +159     
  Misses       2128     2128              
  Partials      361      361              
Impacted Files Coverage Δ
components/file/s3/qiniu/qiniu_oss_client.go 100.00% <100.00%> (ø)
components/file/s3/qiniu/quniu_oss.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8abb21d...6331c1d. Read the comment docs.

wenxuwan
wenxuwan previously approved these changes Mar 7, 2022
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit 13f5154 into mosn:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants