-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make parameters of API plugin extendable #369
Conversation
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 57.97% 58.05% +0.07%
==========================================
Files 106 106
Lines 5633 5638 +5
==========================================
+ Hits 3266 3273 +7
+ Misses 2032 2031 -1
+ Partials 335 334 -1
Continue to review full report at Codecov.
|
# Conflicts: # codecov.yml
…pi_plugin_custom_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # cmd/layotto_multiple_api/main.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Modify parameters of
NewGrpcAPI
to make it extendable. New fields can be added without refactor all the existing api plugins:Modify workflow to run tests parallelly;
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: