Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make parameters of API plugin extendable #369

Merged
merged 12 commits into from
Dec 21, 2021

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Dec 17, 2021

What this PR does:

  1. Modify parameters of NewGrpcAPI to make it extendable. New fields can be added without refactor all the existing api plugins:
    image

  2. Modify workflow to run tests parallelly;
    image

image

  1. Modify codecov configuration to ignore more files

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #369 (5992302) into main (aa38400) will increase coverage by 0.07%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   57.97%   58.05%   +0.07%     
==========================================
  Files         106      106              
  Lines        5633     5638       +5     
==========================================
+ Hits         3266     3273       +7     
+ Misses       2032     2031       -1     
+ Partials      335      334       -1     
Impacted Files Coverage Δ
components/rpc/callback/callback.go 55.55% <ø> (ø)
components/rpc/invoker/mosn/channel/connpool.go 86.04% <ø> (ø)
components/rpc/invoker/mosn/channel/xchannel.go 83.87% <ø> (+3.22%) ⬆️
components/rpc/invoker/mosn/mosninvoker.go 65.00% <ø> (ø)
components/rpc/types.go 53.84% <ø> (ø)
pkg/grpc/default_api/api.go 75.80% <0.00%> (-0.25%) ⬇️
components/rpc/invoker/mosn/channel/httpchannel.go 71.11% <100.00%> (ø)
pkg/actuator/info/endpoint.go 75.00% <100.00%> (+6.81%) ⬆️
pkg/grpc/dapr/dapr_api.go 56.96% <100.00%> (+0.55%) ⬆️
pkg/runtime/runtime.go 54.88% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa38400...5992302. Read the comment docs.

wenxuwan
wenxuwan previously approved these changes Dec 20, 2021
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wenxuwan
wenxuwan previously approved these changes Dec 21, 2021
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhenjunMa
zhenjunMa previously approved these changes Dec 21, 2021
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit 6be4730 into mosn:main Dec 21, 2021
@seeflood seeflood deleted the api_plugin_custom_config branch December 21, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants