-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ADD SECRET API #343
feat: ADD SECRET API #343
Conversation
增加Secret API
增加sum
# Conflicts: # components/go.mod # components/go.sum # go.mod # pkg/grpc/api.go # pkg/grpc/api_test.go # spec/proto/runtime/v1/runtime.pb.go
增加git add操作
Thanks for your contribution ! Tips: you can modify your branch directly without closing and reopening another PR |
OK,I will fix the problem and restart the CI |
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 54.72% 54.95% +0.23%
==========================================
Files 108 111 +3
Lines 5972 6099 +127
==========================================
+ Hits 3268 3352 +84
- Misses 2365 2397 +32
- Partials 339 350 +11
Continue to review full report at Codecov.
|
It has been modified. Please review |
@MoonShining @ZLBer @stulzq @Xunzhuo Hi guys, could you please help review this PR? |
Update:
@MentosL @MoonShining Please review my update |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
@MentosL Hi, are u still working on it ? |
sry,I am a little busy these days, so I can merge it first, and I will submit PR demo separately later |
# Conflicts: # cmd/layotto/main.go # pkg/grpc/default_api/api.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for your contribution !
@MoonShining @ZLBer @wenxuwan @zhenjunMa This pr need one more vote. Could u help ?
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: