Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ADD SECRET API #343

Merged
merged 52 commits into from
Feb 10, 2022
Merged

feat: ADD SECRET API #343

merged 52 commits into from
Feb 10, 2022

Conversation

MentosL
Copy link
Contributor

@MentosL MentosL commented Nov 28, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add secret api

增加Secret API
增加sum
提交本地代码
修改提示语并增加单元测试
# Conflicts:
#	components/go.mod
#	components/go.sum
#	go.mod
#	pkg/grpc/api.go
#	pkg/grpc/api_test.go
#	spec/proto/runtime/v1/runtime.pb.go
重新生成文件
增加git add操作
@seeflood
Copy link
Member

seeflood commented Nov 28, 2021

Thanks for your contribution !
Is this PR ready for review ?
Please format your code with go fmt and add license headers for code files to fix the CI error

Tips: you can modify your branch directly without closing and reopening another PR

@MentosL
Copy link
Contributor Author

MentosL commented Nov 28, 2021

Thanks for your contribution ! Is this PR ready for review ? Please format your code with go fmt and add license headers for code files to fix the CI error

Tips: you can modify your branch directly without closing and reopening another PR

OK,I will fix the problem and restart the CI

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #343 (195af07) into main (771c8c7) will increase coverage by 0.23%.
The diff coverage is 70.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   54.72%   54.95%   +0.23%     
==========================================
  Files         108      111       +3     
  Lines        5972     6099     +127     
==========================================
+ Hits         3268     3352      +84     
- Misses       2365     2397      +32     
- Partials      339      350      +11     
Impacted Files Coverage Δ
pkg/runtime/config.go 60.00% <ø> (ø)
pkg/runtime/options.go 12.76% <0.00%> (-0.88%) ⬇️
pkg/grpc/dapr/dapr_api_secret.go 53.70% <53.70%> (ø)
pkg/runtime/runtime.go 53.87% <71.05%> (-1.02%) ⬇️
pkg/grpc/default_api/api.go 73.96% <84.84%> (+0.89%) ⬆️
pkg/grpc/dapr/dapr_api.go 58.53% <100.00%> (+1.57%) ⬆️
pkg/runtime/secretstores/factory.go 100.00% <100.00%> (ø)
pkg/runtime/secretstores/registry.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771c8c7...195af07. Read the comment docs.

@MentosL
Copy link
Contributor Author

MentosL commented Nov 28, 2021

Thanks for your contribution ! Is this PR ready for review ? Please format your code with go fmt and add license headers for code files to fix the CI error

Tips: you can modify your branch directly without closing and reopening another PR

It has been modified. Please review

@seeflood
Copy link
Member

@MoonShining @ZLBer @stulzq @Xunzhuo Hi guys, could you please help review this PR?
Since adding new API is important to us ,we need more people reviewing it :)

components/go.sum Outdated Show resolved Hide resolved
components/secretstores/secret_store.go Outdated Show resolved Hide resolved
@seeflood seeflood changed the title ADD SECRET API feat: ADD SECRET API Dec 1, 2021
@seeflood
Copy link
Member

Update:

  1. move secret api code from dapr_api_unimplement.go to a dapr_api_secret.go
  2. modify secret api code in api.go
  3. I removed actuator related code in initSecretStores. Currently the actuator can not tell difference between redis state store and redis lock store. Need to re-design it in the future.
    image

@MentosL @MoonShining Please review my update

pkg/runtime/secretstores/registry.go Outdated Show resolved Hide resolved
@seeflood seeflood linked an issue Jan 7, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 7, 2022
@seeflood
Copy link
Member

seeflood commented Feb 8, 2022

@MentosL Hi, are u still working on it ?
If you don't have time recently, maybe we can merge this PR and then add demos in some other PR.

@MentosL
Copy link
Contributor Author

MentosL commented Feb 8, 2022

sry,I am a little busy these days, so I can merge it first, and I will submit PR demo separately later

# Conflicts:
#	cmd/layotto/main.go
#	pkg/grpc/default_api/api.go
pkg/runtime/secretstores/registry.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stale label Feb 9, 2022
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for your contribution !
@MoonShining @ZLBer @wenxuwan @zhenjunMa This pr need one more vote. Could u help ?

@seeflood seeflood merged commit 178f6ef into mosn:main Feb 10, 2022
seeflood pushed a commit to seeflood/layotto that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal]Secret API design
4 participants