Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js-sdk): add Node.js SDK #262

Closed
wants to merge 13 commits into from
Closed

feat(js-sdk): add Node.js SDK #262

wants to merge 13 commits into from

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Oct 17, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #258

Special notes for your reviewer:

  • State API
  • File API
  • Sequencer API
  • Distributed Lock API
  • Pub/Sub API
  • RPC API
  • Binding API

Does this PR introduce a user-facing change?:


@mosn-community-bot
Copy link

Hi @fengmk2, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@fengmk2 fengmk2 force-pushed the js-sdk branch 6 times, most recently from afa721d to 21bca98 Compare October 24, 2021 06:20
@fengmk2 fengmk2 changed the title [WIP] add Node.js SDK Client add Node.js SDK Client Oct 24, 2021
@fengmk2
Copy link
Contributor Author

fengmk2 commented Oct 24, 2021

State API finished, and all unit tests pass on local env
image

@fengmk2 fengmk2 force-pushed the js-sdk branch 2 times, most recently from 41c6da9 to 169e913 Compare October 24, 2021 16:31
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #262 (ef81bcf) into main (7a133d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   56.65%   56.65%           
=======================================
  Files          48       48           
  Lines        2058     2058           
=======================================
  Hits         1166     1166           
  Misses        769      769           
  Partials      123      123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a133d2...ef81bcf. Read the comment docs.

@seeflood
Copy link
Member

seeflood commented Oct 25, 2021

I fixed the ut failure of sequencer and lock ,and added license headers for code files.
You can use a one line command to automatically add license headers, see https://mosn.io/layotto/#/zh/development/explanation-for-github-workflow?id=how-to-add-license-headers-for-all-files-automatically

@seeflood seeflood changed the title add Node.js SDK Client feat: add Node.js SDK Client Oct 26, 2021
@fengmk2 fengmk2 force-pushed the js-sdk branch 2 times, most recently from 1a664d8 to 277fc92 Compare October 30, 2021 07:52
@fengmk2 fengmk2 changed the title feat: add Node.js SDK Client feat: add Node.js SDK Oct 30, 2021
@fengmk2
Copy link
Contributor Author

fengmk2 commented Oct 31, 2021

@seeflood 所有已知的 API 都实现了,可以 review 了。

@seeflood
Copy link
Member

seeflood commented Oct 31, 2021

Thanks for your contribution!
I will modify the check license configuration and add license headers for your code once the code review finished (to avoid be overwrited by your push) So ignore the CI warning for now :)

@fengmk2 fengmk2 changed the title feat: add Node.js SDK feat(js-sdk): add Node.js SDK Nov 3, 2021
}
}
},
"pub_subs": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里配置没有生效

fengmk2 added a commit to layotto/js-sdk that referenced this pull request Nov 14, 2021
@fengmk2
Copy link
Contributor Author

fengmk2 commented Nov 14, 2021

@fengmk2 fengmk2 closed this Nov 14, 2021
@seeflood
Copy link
Member

Hi @fengmk2 ,it seems that we still need part of your PR, like:

  • jstype in runtime.proto
    image

  • configs/config_integration_redis_etcd.json

  • Makefile
    image

Could u please submit a PR only including these ? Or should I just reopen and modify this PR

@fengmk2
Copy link
Contributor Author

fengmk2 commented Nov 15, 2021

@seeflood new PR landed #316

@fengmk2 fengmk2 closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nodejs SDK
2 participants