Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ci): deadlink checker didn't find the wrong url in sidebar #799

Open
seeflood opened this issue Sep 26, 2022 · 4 comments
Open

bug(ci): deadlink checker didn't find the wrong url in sidebar #799

seeflood opened this issue Sep 26, 2022 · 4 comments
Labels
help wanted Extra attention is needed kind/bug

Comments

@seeflood
Copy link
Member

What happened:
@wenxuwan found that the link in the sidebar is wrong, see https://mosn.io/layotto/#/zh/design/oss/oss-api-design
image

The problem is that our deadlink checker didn't find it :(
The checker runs successfully without noticing this link:
https://github.com/mosn/layotto/actions/workflows/dead-link-checker.yaml
image

What you expected to happen:
deadlink checker should find out the wrong urls

How to reproduce it (as minimally and precisely as possible):
open https://mosn.io/layotto/#/zh/design/oss/oss-api-design

Anything else we need to know?:

@seeflood seeflood added kind/bug help wanted Extra attention is needed labels Sep 26, 2022
@seeflood
Copy link
Member Author

cc @Xunzhuo

@seeflood
Copy link
Member Author

seeflood commented Sep 26, 2022

I found that curl -w %{http_code} https://mosn.io/layotto/#/zh/design/oss/oss-api-design returns 200, not 404
So it's docsify's problem, not our deadlink checker's problem. :(
This issue is not a high priority

@rayowang
Copy link
Member

rayowang commented Nov 5, 2022

This looks like a routing problem with webserver configuration.

@seeflood
Copy link
Member Author

seeflood commented Nov 5, 2022

Yes, but I don't know how to configure the docsify server to fix this issue 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/bug
Projects
None yet
Development

No branches or pull requests

2 participants