Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gengrate other language pb files #79

Closed
jxljf opened this issue Jun 22, 2021 · 7 comments
Closed

gengrate other language pb files #79

jxljf opened this issue Jun 22, 2021 · 7 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@jxljf
Copy link
Contributor

jxljf commented Jun 22, 2021

What would you like to be added:
other languane call layotto need user self gengerate pb client

Why is this needed:
easy to call layotto by other language

@zhenjunMa zhenjunMa added the help wanted Extra attention is needed label Jun 22, 2021
@seeflood
Copy link
Member

seeflood commented Jun 25, 2021

Thanks for your feedback!
In the first version,the sdk can be as simple as possible,which might only have some pb files in it

@MentosL
Copy link
Contributor

MentosL commented Jun 25, 2021

There are PB files in other languages for reference ? I'm interested in it

@alpha-baby
Copy link
Member

There are PB files in other languages for reference ? I'm interested in it

appcalback.proto file, wo can add java option

option java_outer_classname = "LayottoAppCallbackProtos";
option java_package = "io.mosn.layotto.v1";

runtime.proto file, wo can add java option

option java_outer_classname = "LayottoProtos";
option java_package = "io.mosn.layotto.v1";

@seeflood
Copy link
Member

seeflood commented Jun 25, 2021

@MentosL

the proto files is under "/spec/proto/runtime/v1/" directory,see:
https://github.com/mosn/layotto/blob/main/spec/proto/runtime/v1/runtime.proto
https://github.com/mosn/layotto/blob/main/spec/proto/runtime/v1/appcallback.proto

there are already pb files in golang:
https://github.com/mosn/layotto/blob/main/spec/proto/runtime/v1/runtime.pb.go
https://github.com/mosn/layotto/blob/main/spec/proto/runtime/v1/appcallback.pb.go

and the golang sdk in under "/sdk/go-sdk" directory:
https://github.com/mosn/layotto/tree/main/sdk/go-sdk

you can add some other sdk like "/sdk/java-sdk" or "/sdk/nodejs-sdk" or "/sdk/python-sdk" etc.

The golang sdk has many api,but we don't have to implement them all for other languages in the first version.
Maybe a simple sdk project that only imports the PB files is enough(e.g. a java maven project imports the java pb files),so that java or python or nodejs users don't have to generate these files themselves.

@seeflood
Copy link
Member

@MentosL
So can I assign this feature to you?

@MentosL
Copy link
Contributor

MentosL commented Jun 25, 2021

Yes, I'll do my best

@seeflood
Copy link
Member

Yes, I'll do my best

Cool.Feel free to ask for help,and welcome to the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants