Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a "basic" dockerfile #628

Closed
seeflood opened this issue Jun 4, 2022 · 2 comments
Closed

Develop a "basic" dockerfile #628

seeflood opened this issue Jun 4, 2022 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@seeflood
Copy link
Member

seeflood commented Jun 4, 2022

What would you like to be added:
Currently there's a runtime_config.json in the Layotto dockerfile:
image

If users want to modify the json file, they have to write a new dockerfile and generate a new docker image, which is annoying.

We should provide a "basic" dockerfile, which is common enough and decoupled with the config.json, so that it can be used with any config.json files.
Users can deploy our "basic" docker image with their own config.json, by mounting volumes or writing their own dockerfile based on it

Why is this needed:
Make Layotto more user-friendly.
It's a subtask of #392

@seeflood seeflood added kind/enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 4, 2022
@Xunzhuo
Copy link
Member

Xunzhuo commented Jun 5, 2022

Sorry, I think the old dockerfile has been modified into a generic one? How does the IMAGEBUILD directory generate? I think I have removed them.

@seeflood
Copy link
Member Author

seeflood commented Jun 7, 2022

@Xunzhuo Yes you are right!
I rechecked the project and found that the IMAGEBUILD is a legacy directory in my local file system.
I will close this issue and write a document on "how to play quickstart with docker"

@seeflood seeflood closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants