Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add more linters to make our CI stricter; 在CI中添加更多 linter #599

Open
2 tasks
seeflood opened this issue May 23, 2022 · 0 comments
Open
2 tasks

ci: add more linters to make our CI stricter; 在CI中添加更多 linter #599

seeflood opened this issue May 23, 2022 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/ci priority/medium

Comments

@seeflood
Copy link
Member

seeflood commented May 23, 2022 •
edited
Loading

What would you like to be added:
Add more linters, including:

  • make sure that all the type assertions are handled safely, using forcetypeassert
    image

  • make sure every error is handled using errcheck

- [ ] no global variables in component package

Why is this needed:
A stricter linter can make code review easier
@seeflood seeflood changed the title ci: make the linter stricter ci: add more linters and make our CI stricter May 23, 2022
@seeflood seeflood added good first issue Good for newcomers help wanted Extra attention is needed area/ci labels May 23, 2022
@seeflood seeflood changed the title ci: add more linters and make our CI stricter ci: add more linters to make our CI stricter May 23, 2022
This was referenced May 24, 2022
Closed
Open
@seeflood seeflood changed the title ci: add more linters to make our CI stricter ci: add more linters to make our CI stricter; 在CI中添加更多 linter Jun 14, 2022
@Kelei0215 Kelei0215 mentioned this issue Jun 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/ci priority/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seeflood