Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no compilation flags for version #521

Closed
Tracked by #532
seeflood opened this issue May 1, 2022 · 0 comments · Fixed by #522 or #517
Closed
Tracked by #532

no compilation flags for version #521

seeflood opened this issue May 1, 2022 · 0 comments · Fixed by #522 or #517
Assignees
Labels
bug Something isn't working

Comments

@seeflood
Copy link
Member

seeflood commented May 1, 2022

What happened:
I just found a problem with version.
Layotto used compilation flags to modify the Version variable in main.go and :
image
But we removed the flags in new CI , which leads to some issues.
For example, if you run the layotto binary, there's no version information in the printed message:
image

Besides, the actuator API can't get the right version.

What you expected to happen:
add compilation flags for version

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants