-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail fast and kill the process when error occurs during startup #275
Comments
在本地修改redis的配置文件端口测试后,这里是否存在问题还是我的测试方法不对
Dapr里对于Runtime组件的初始化 |
恩恩设计目标是在init的时候如果error 干脆就别启动; |
据 @whalesongAndLittleFish 反馈,其实启动时候报错了但是没看到。流程是: 这有点问题:理论上Layotto启动报错就应该自杀掉,fail fast,为啥会正常启动? |
刚找@nejisama 讨论了,总结下 问题:启动时候Layotto报错、没正常初始化,但是不影响mosn启动,这就导致mosn还活着,layotto是死的,进程虽然启动了,但是部分功能是挂的。但是本着fail fast的思想,最好能直接kill掉进程 生产用户的需求:有的生产用户可能希望别自动kill,kill掉就没日志查了 修复方案:
@zach030 @stulzq @whalesongAndLittleFish FYI,总算搞明白这个问题了……我先把修复这个问题记个社区任务吧,或者各位大佬感兴趣也可以修一下 |
According to feedback from @stulzq and @whalesongAndLittleFish ,when Layotto can not connect to the redis server(for example,you wrote a wrong redis port in the Layotto configuration file), the logs are not detailed and we can't find out why error happens.
Steps to reproduce:
But the server logs are not detailed,you can't find out why:
What would you like to be added:
Add detailed log when grpc API error
Chinese:
目前Layotto配置配错了、连接redis异常时,client调分布式锁API会报错,但是从日志中看不出来为啥报错
需要优化日志,连接redis异常时打印更详细的日志,方便排查。
The text was updated successfully, but these errors were encountered: