-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the risk of panic #197
Comments
I am happy to do this work, can you assign this issue to me? |
Cool ! |
I'm very excited to do this work, pls assign this issue to me! thx a lot |
Ah,sorry that I just assigned this issue to @arcosx |
Sorry for my late submission🤣, I submitted a PR #208 regarding the first solution point: One question, should my changes involve the directories |
@arcosx Thanks for your contribution! |
What would you like to be added:
Layotto(open source version) will be imported and deployed in the production environment.
Thanks to golang's weird design,a panic in a third-party library will bring down the whole process, which means a panic bug can bring down the whole cluster.
Since that, we must reduce the risk of
panic
before deploying Layotto in the production environment.Tasks included:
go func(){xxx}
) with recover phrase( e.g.utils.GoWithRecover(func() { xxx }
)main.go
and it has the risk of dependency conflicts.To reduce the risk,we can let users decide which components should be imported and which should not.But it takes time to do some research and careful design.chinese:
go func(){xxx}
)加上recover(直接用工具类即可,utils.GoWithRecover(func() { xxx }
)注:新手任务只需要做第一个就行(给所有创建新协程的地方加上recover),不用管第二个,第二个我来调研一下
Why is this needed:
Make Layotto more robust
The text was updated successfully, but these errors were encountered: