Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for runtime/runtime.go and grpc/api.go #138

Closed
seeflood opened this issue Jul 14, 2021 · 5 comments · Fixed by #169
Closed

Add unit tests for runtime/runtime.go and grpc/api.go #138

seeflood opened this issue Jul 14, 2021 · 5 comments · Fixed by #169
Assignees

Comments

@seeflood
Copy link
Member

What would you like to be added:
Add unit tests for runtime/runtime.go and grpc/api.go.
These two files are the core engine code of Layotto, responsible for component lifecycle management and grpc request processing respectively.

chinese:
为runtime/runtime.go和grpc/api.go添加单元测试。这两个文件是layotto的核心引擎代码,各自负责组件生命周期管理(启动、注册、初始化)和grpc请求处理,完成此任务可以很好的了解Layotto架构

Why is this needed:
Currently our test coverage is not high :(

@seeflood
Copy link
Member Author

Assigned to @tianjipeng
Thanks for your passion!

@tianjipeng
Copy link
Member

OK

@seeflood
Copy link
Member Author

seeflood commented Aug 5, 2021

@tianjipeng Hi, are you still working on it?

@tianjipeng
Copy link
Member

I wiil commit a pr this weekend

@seeflood
Copy link
Member Author

seeflood commented Aug 5, 2021

I wiil commit a pr this weekend

Fine.If you find some code or module difficult to understand,just tell me and I will add comments and document for that module first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants