Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for RPC related code #106

Closed
seeflood opened this issue Jul 2, 2021 · 3 comments · Fixed by #115
Closed

Add unit tests for RPC related code #106

seeflood opened this issue Jul 2, 2021 · 3 comments · Fixed by #115
Assignees
Labels
help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@seeflood
Copy link
Member

seeflood commented Jul 2, 2021

What would you like to be added:
Understand the implementation of the rpc module and add unit tests for it, so that the test coverage of the module reaches 80%
You can ask @MoonShining for help if you encounter any problems in the process.
The code path is in components/rpc
In addition, there are rpc related codes in pkg/grpc/api.go and pkg/runtime/runtime.go files

Reference materials:rpc design document

After completing this improvement, you will learn the principle of Layotto supporting rpc, how Layotto and mosn are integrated to reuse service mesh capabilities

chinese:
看明白rpc模块的实现原理并为rpc相关模块补充单测,使模块的单测覆盖率达到80%
过程中遇到问题可以问 @MoonShining
代码路径在 components/rpc
另外pkg/grpc/api.go 和pkg/runtime/runtime.go 文件里也有rpc相关的代码

参考资料:rpc设计文档

完成这项优化后,你将学习到Layotto支持rpc的原理、Layotto是如何和mosn整合到一起复用service mesh能力的

Why is this needed:
Currently the test coverage of rpc component is not high:
image

@seeflood seeflood added kind/enhancement New feature or request help wanted Extra attention is needed labels Jul 2, 2021
@seeflood
Copy link
Member Author

seeflood commented Jul 2, 2021

@tianjipeng Hi,you can reply here
It seems a github rule that I can't assign it to you until you reply here

@tianjipeng
Copy link
Member

Ok,please assign to me

@seeflood
Copy link
Member Author

seeflood commented Jul 2, 2021

Ok, already assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants