Skip to content

Commit c232ee5

Browse files
authored
chore: demo should panic when errors occur (#650)
* demo should panic Signed-off-by: seeflood <[email protected]> * go mod tidy Signed-off-by: seeflood <[email protected]> * fix Signed-off-by: seeflood <[email protected]> * fix Signed-off-by: seeflood <[email protected]> * fix minio error messages Signed-off-by: seeflood <[email protected]> * delete redundent demos Signed-off-by: seeflood <[email protected]>
1 parent 1576bc7 commit c232ee5

File tree

14 files changed

+30
-828
lines changed

14 files changed

+30
-828
lines changed

demo/bindings/main.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ import (
1212
func main() {
1313
conn, err := grpc.Dial("127.0.0.1:34904", grpc.WithInsecure())
1414
if err != nil {
15-
fmt.Printf("conn build failed,err:%+v", err)
16-
return
15+
panic(err)
1716
}
1817

1918
c := runtimev1pb.NewRuntimeClient(conn)

demo/configuration/common/client.go

+6-9
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,7 @@ func testSubscribeWithSDK(ctx context.Context, cli client.Client) {
101101
go func() {
102102
for resp := range ch {
103103
if resp.Err != nil {
104-
fmt.Println("subscribe failed", resp.Err)
105-
continue
104+
panic(resp.Err)
106105
}
107106
marshal, err := json.Marshal(resp.Item)
108107
if err != nil {
@@ -193,9 +192,8 @@ func testSet(ctx context.Context, cli client.Client) {
193192
saveRequest := &client.SaveConfigurationRequest{StoreName: storeName, AppId: appid}
194193
saveRequest.Items = append(saveRequest.Items, item1)
195194
saveRequest.Items = append(saveRequest.Items, item2)
196-
if cli.SaveConfiguration(ctx, saveRequest) != nil {
197-
fmt.Println("save key failed")
198-
return
195+
if err := cli.SaveConfiguration(ctx, saveRequest); err != nil {
196+
panic(err)
199197
}
200198
fmt.Println("save key success")
201199
}
@@ -205,7 +203,7 @@ func testGet(ctx context.Context, cli client.Client) {
205203
items, err := cli.GetConfiguration(ctx, getRequest)
206204
//validate
207205
if err != nil {
208-
fmt.Printf("get configuration failed %+v \n", err)
206+
panic(err)
209207
}
210208
for _, item := range items {
211209
fmt.Printf("get configuration after save, %+v \n", item)
@@ -214,9 +212,8 @@ func testGet(ctx context.Context, cli client.Client) {
214212

215213
func testDelete(ctx context.Context, cli client.Client) {
216214
request := &client.ConfigurationRequestItem{StoreName: storeName, AppId: appid, Group: group, Label: "prod", Keys: []string{"key1", "haha"}}
217-
if cli.DeleteConfiguration(ctx, request) != nil {
218-
fmt.Println("delete key failed")
219-
return
215+
if err := cli.DeleteConfiguration(ctx, request); err != nil {
216+
panic(err)
220217
}
221218
fmt.Printf("delete keys success\n")
222219
}

demo/file/client.go

+15-9
Original file line numberDiff line numberDiff line change
@@ -24,39 +24,44 @@ const (
2424
)
2525

2626
func TestGet(fileName string) {
27+
// dial
2728
conn, err := grpc.Dial("127.0.0.1:34904", grpc.WithInsecure())
2829
if err != nil {
2930
fmt.Printf("conn build failed,err:%+v", err)
30-
return
31+
panic(err)
3132
}
3233

34+
// new client
3335
c := runtimev1pb.NewRuntimeClient(conn)
36+
37+
// getFile
3438
req := &runtimev1pb.GetFileRequest{StoreName: storeName, Name: fileName}
3539
cli, err := c.GetFile(context.Background(), req)
3640
if err != nil {
3741
fmt.Printf("get file error: %+v", err)
38-
return
42+
panic(err)
3943
}
4044
pic := make([]byte, 0)
4145
for {
4246
resp, err := cli.Recv()
4347
if err != nil {
44-
fmt.Println("recv file failed")
4548
if err.Error() != "EOF" {
49+
fmt.Println("recv file failed")
4650
panic(err)
4751
}
4852
break
4953
}
5054
pic = append(pic, resp.Data...)
5155
}
56+
fmt.Println("GetFile successfully. Result:")
5257
fmt.Println(string(pic))
5358
}
5459

5560
func TestPut(fileName string, value string) {
5661
conn, err := grpc.Dial("127.0.0.1:34904", grpc.WithInsecure())
5762
if err != nil {
5863
fmt.Printf("conn build failed,err:%+v", err)
59-
return
64+
panic(err)
6065
}
6166
meta := make(map[string]string)
6267
meta["storageType"] = storageType
@@ -65,21 +70,22 @@ func TestPut(fileName string, value string) {
6570
stream, err := c.PutFile(context.TODO())
6671
if err != nil {
6772
fmt.Printf("put file failed:%+v", err)
68-
return
73+
panic(err)
6974
}
7075
req.Data = []byte(value)
7176
stream.Send(req)
7277
_, err = stream.CloseAndRecv()
7378
if err != nil {
7479
fmt.Printf("cannot receive response: %+v", err)
80+
panic(err)
7581
}
7682
}
7783

7884
func TestList(bucketName string) {
7985
conn, err := grpc.Dial("127.0.0.1:34904", grpc.WithInsecure())
8086
if err != nil {
8187
fmt.Printf("conn build failed,err:%+v", err)
82-
return
88+
panic(err)
8389
}
8490
meta := make(map[string]string)
8591
meta["storageType"] = storageType
@@ -91,7 +97,7 @@ func TestList(bucketName string) {
9197
resp, err := c.ListFile(context.Background(), listReq)
9298
if err != nil {
9399
fmt.Printf("list file fail, err: %+v", err)
94-
return
100+
panic(err)
95101
}
96102
marker = resp.Marker
97103
if !resp.IsTruncated {
@@ -118,7 +124,7 @@ func TestDel(fileName string) {
118124
_, err = c.DelFile(context.Background(), listReq)
119125
if err != nil {
120126
fmt.Printf("list file fail, err: %+v \n", err)
121-
return
127+
panic(err)
122128
}
123129
fmt.Printf("delete file success \n")
124130
}
@@ -127,7 +133,7 @@ func TestStat(fileName string) {
127133
conn, err := grpc.Dial("127.0.0.1:34904", grpc.WithInsecure())
128134
if err != nil {
129135
fmt.Printf("conn build failed,err:%+v", err)
130-
return
136+
panic(err)
131137
}
132138
meta := make(map[string]string)
133139
meta["storageType"] = storageType

demo/lock/consul/client.go

-113
This file was deleted.

demo/lock/etcd/client.go

-113
This file was deleted.

0 commit comments

Comments
 (0)