Fix offences by rubocop supporting autocorrection

Author: pyromaniac

.rubocop_todo.yml

@@ -1,14 +1,14 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-09-06 11:35:34 +0700 using RuboCop version 0.42.0.
+# on 2016-09-06 12:08:00 +0700 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 42
+# Offense count: 41
 Metrics/AbcSize:
-  Max: 49
+  Max: 47
 
 # Offense count: 4
 # Configuration parameters: CountComments.
@@ -19,7 +19,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 13
 
-# Offense count: 1476
+# Offense count: 1455
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
 # URISchemes: http, https
 Metrics/LineLength:
@@ -51,15 +51,6 @@ Style/AsciiComments:
     - 'lib/chewy/type/mapping.rb'
     - 'spec/chewy_spec.rb'
 
-# Offense count: 6
-# Cop supports --auto-correct.
-Style/CharacterLiteral:
-  Exclude:
-    - 'lib/chewy.rb'
-    - 'lib/chewy/index.rb'
-    - 'lib/chewy/query/nodes/field.rb'
-    - 'lib/tasks/chewy.rake'
-
 # Offense count: 1
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: nested, compact
@@ -71,72 +62,6 @@ Style/ClassAndModuleChildren:
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAdjacentOneLineDefs.
-Style/EmptyLineBetweenDefs:
-  Exclude:
-    - 'lib/chewy/strategy/base.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Style/EmptyLines:
-  Exclude:
-    - 'spec/chewy/fields/base_spec.rb'
-    - 'spec/chewy/query/nodes/has_child_spec.rb'
-    - 'spec/chewy/query/nodes/has_parent_spec.rb'
-    - 'spec/chewy/query/pagination/will_paginage_spec.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/EmptyLinesAroundAccessModifier:
-  Exclude:
-    - 'lib/chewy/minitest/search_index_receiver.rb'
-    - 'lib/chewy/query/nodes/has_child.rb'
-    - 'lib/chewy/query/nodes/has_parent.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, no_empty_lines
-Style/EmptyLinesAroundClassBody:
-  Exclude:
-    - 'lib/chewy/index/settings.rb'
-    - 'lib/chewy/minitest/search_index_receiver.rb'
-    - 'lib/chewy/rake_helper.rb'
-    - 'lib/chewy/type/adapter/active_record.rb'
-    - 'lib/chewy/type/adapter/mongoid.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, no_empty_lines
-Style/EmptyLinesAroundModuleBody:
-  Exclude:
-    - 'lib/chewy.rb'
-    - 'lib/chewy/minitest/helpers.rb'
-    - 'lib/chewy/query/compose.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Style/ExtraSpacing:
-  Exclude:
-    - 'Guardfile'
-    - 'lib/chewy/railtie.rb'
-    - 'spec/chewy/index_spec.rb'
-    - 'spec/chewy/query_spec.rb'
-    - 'spec/chewy/type/import_spec.rb'
-
-# Offense count: 13
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
-Style/FirstParameterIndentation:
-  Exclude:
-    - 'spec/chewy/fields/base_spec.rb'
-    - 'spec/chewy/type/import_spec.rb'
-
 # Offense count: 2
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
@@ -149,13 +74,6 @@ Style/IfInsideElse:
   Exclude:
     - 'lib/chewy/rspec/update_index.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'lib/chewy/minitest/helpers.rb'
-
 # Offense count: 2
 Style/IfUnlessModifierOfIfUnless:
   Exclude:
@@ -181,14 +99,6 @@ Style/MultilineBlockChain:
     - 'lib/chewy/type/import.rb'
     - 'lib/chewy/type/observe.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: aligned, indented
-Style/MultilineOperationIndentation:
-  Exclude:
-    - 'lib/chewy/rspec/update_index.rb'
-
 # Offense count: 7
 Style/MultilineTernaryOperator:
   Exclude:
@@ -199,93 +109,32 @@ Style/MultilineTernaryOperator:
     - 'lib/chewy/type/adapter/orm.rb'
     - 'lib/chewy/type/observe.rb'
 
-# Offense count: 10
-# Cop supports --auto-correct.
-Style/MutableConstant:
-  Exclude:
-    - 'lib/chewy/query/criteria.rb'
-    - 'lib/chewy/query/nodes/bool.rb'
-    - 'lib/chewy/query/nodes/equal.rb'
-    - 'lib/chewy/query/nodes/range.rb'
-    - 'lib/chewy/query/nodes/regexp.rb'
-    - 'lib/chewy/type.rb'
-    - 'lib/chewy/type/import.rb'
-    - 'lib/chewy/version.rb'
-    - 'spec/support/mongoid.rb'
-
-# Offense count: 13
-# Cop supports --auto-correct.
-Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'spec/chewy/minitest/search_index_receiver_spec.rb'
-    - 'spec/chewy/type/adapter/active_record_spec.rb'
-    - 'spec/chewy/type/adapter/mongoid_spec.rb'
-    - 'spec/chewy/type/adapter/object_spec.rb'
-    - 'spec/chewy/type/adapter/sequel_spec.rb'
-    - 'spec/chewy/type/import_spec.rb'
-
 # Offense count: 2
 Style/NestedTernaryOperator:
   Exclude:
     - 'lib/chewy/fields/base.rb'
     - 'lib/chewy/type/adapter/orm.rb'
 
-# Offense count: 5
+# Offense count: 3
 # Cop supports --auto-correct.
 Style/NilComparison:
   Exclude:
     - 'spec/chewy/query/filters_spec.rb'
-    - 'spec/chewy/query/nodes/exists_spec.rb'
     - 'spec/chewy/query/nodes/missing_spec.rb'
 
-# Offense count: 2
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: IncludeSemanticChanges.
 Style/NonNilCheck:
   Exclude:
     - 'spec/chewy/query/filters_spec.rb'
     - 'spec/chewy/query/nodes/exists_spec.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-Style/NumericLiterals:
-  MinDigits: 6
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: predicate, comparison
-Style/NumericPredicate:
-  Exclude:
-    - 'lib/chewy/fields/base.rb'
-    - 'lib/chewy/fields/root.rb'
-    - 'lib/chewy/runtime/version.rb'
-    - 'lib/chewy/type/observe.rb'
-    - 'lib/chewy/type/witchcraft.rb'
-
 # Offense count: 8
 Style/OpMethod:
   Exclude:
     - 'lib/chewy/query/nodes/field.rb'
 
-# Offense count: 5
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
-  Exclude:
-    - 'lib/chewy/fields/base.rb'
-    - 'lib/chewy/query/nodes/bool.rb'
-    - 'lib/chewy/query/nodes/prefix.rb'
-    - 'lib/chewy/type/crutch.rb'
-    - 'lib/chewy/type/mapping.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'lib/chewy/journal.rb'
-    - 'spec/chewy/type/witchcraft_spec.rb'
-
 # Offense count: 2
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
 # NamePrefix: is_, has_, have_
@@ -295,158 +144,3 @@ Style/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'lib/chewy/query/filters.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/Proc:
-  Exclude:
-    - 'lib/chewy/type/observe.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: compact, exploded
-Style/RaiseArgs:
-  Exclude:
-    - 'lib/chewy.rb'
-    - 'lib/chewy/query.rb'
-    - 'lib/chewy/strategy/base.rb'
-    - 'lib/chewy/type/import.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/chewy/config.rb'
-    - 'lib/chewy/repository.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'spec/chewy_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/RescueModifier:
-  Exclude:
-    - 'spec/chewy/type/import_spec.rb'
-
-# Offense count: 35
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Exclude:
-    - 'spec/chewy/query/criteria_spec.rb'
-    - 'spec/chewy/strategy/atomic_spec.rb'
-    - 'spec/chewy/type/adapter/active_record_spec.rb'
-    - 'spec/chewy/type/adapter/mongoid_spec.rb'
-    - 'spec/chewy/type/adapter/object_spec.rb'
-    - 'spec/chewy/type/adapter/sequel_spec.rb'
-    - 'spec/chewy/type/import_spec.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Style/SpaceAfterColon:
-  Exclude:
-    - 'spec/chewy/query/pagination/will_paginage_spec.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-Style/SpaceAfterComma:
-  Exclude:
-    - 'lib/chewy/minitest/search_index_receiver.rb'
-    - 'spec/chewy/minitest/helpers_spec.rb'
-    - 'spec/chewy/minitest/search_index_receiver_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: space, no_space
-Style/SpaceAroundEqualsInParameterDefault:
-  Exclude:
-    - 'lib/chewy/query/pagination/will_paginate.rb'
-
-# Offense count: 21
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Style/SpaceAroundOperators:
-  Exclude:
-    - 'lib/chewy/runtime/version.rb'
-    - 'spec/chewy/fields/base_spec.rb'
-    - 'spec/chewy/query_spec.rb'
-    - 'spec/chewy/search_spec.rb'
-    - 'spec/chewy/type/adapter/active_record_spec.rb'
-    - 'spec/chewy/type/adapter/mongoid_spec.rb'
-    - 'spec/chewy/type/adapter/sequel_spec.rb'
-    - 'spec/chewy/type/import_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/SpaceBeforeComment:
-  Exclude:
-    - 'spec/support/sequel.rb'
-
-# Offense count: 14
-# Cop supports --auto-correct.
-Style/SpaceInsideBrackets:
-  Exclude:
-    - 'lib/chewy/rake_helper.rb'
-    - 'spec/chewy/query/criteria_spec.rb'
-    - 'spec/chewy/query_spec.rb'
-
-# Offense count: 24
-# Cop supports --auto-correct.
-Style/SpaceInsideParens:
-  Exclude:
-    - 'spec/chewy/type/adapter/sequel_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: space, no_space
-Style/SpaceInsideStringInterpolation:
-  Exclude:
-    - 'lib/chewy/rspec/update_index.rb'
-
-# Offense count: 50
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: final_newline, final_blank_line
-Style/TrailingBlankLines:
-  Exclude:
-    - 'lib/chewy/rspec.rb'
-    - 'lib/generators/chewy/install_generator.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
-# SupportedStyles: comma, consistent_comma, no_comma
-Style/TrailingCommaInArguments:
-  Exclude:
-    - 'spec/chewy/fields/time_fields_spec.rb'
-    - 'spec/chewy/query/filters_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
-# SupportedStyles: comma, consistent_comma, no_comma
-Style/TrailingCommaInLiteral:
-  Exclude:
-    - 'lib/chewy/query/nodes/equal.rb'
-    - 'lib/chewy/query/nodes/range.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/WhileUntilDo:
-  Exclude:
-    - 'lib/chewy/type/import.rb'