Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable axes individually #253

Merged
merged 2 commits into from
Oct 12, 2013

Conversation

omarkhan
Copy link
Contributor

I need to hide only the y axis labels. I tried setting yLabelFormat to a function that returns the empty string, but that broke the number displayed in the hover popup.

This patch extends the axes option to allow true, false, 'both', 'x', or 'y'

@tiraeth
Copy link
Contributor

tiraeth commented Jun 23, 2013

I would go with different values for axes instead of separate options, like:

  • true or both for both enabled
  • false for both disabled
  • x for X enabled, Y disabled
  • y for X disabled, Y enabled

The advantage of the proposed solution is that we're not introducing BCB (you don't do so either but this don't add additional options).

@omarkhan
Copy link
Contributor Author

@tiraeth done in d142048

@oesmith
Copy link
Contributor

oesmith commented Oct 12, 2013

Awesome work again! If you could do another PR for docs, that would be amazing 👍

Thanks!

@oesmith oesmith merged commit d142048 into morrisjs:master Oct 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants