Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent section expanding and collapsing in the left panel of the browser UI #2844

Closed
Alegom opened this issue Feb 5, 2025 · 4 comments
Assignees
Labels

Comments

@Alegom
Copy link

Alegom commented Feb 5, 2025

Describe the bug
In the left panel of the browser UI, when switching between different sections the current section does not collapse when selecting a new section if a sub-section was selected before and selecting a new sub-section finally does it.

To Reproduce

  1. Select History and observe it expand.
  2. Select Settings and observe History collapse and Settings expand.
  3. Select History and observe Settings collapse and History expand.
  4. Select Settings and then General and observe History collapse and Settings expand.
  5. Select History and observe History expand while keeping Settings expanded.
  6. Select Episodes inside History and observe Settings finally collapse.

Expected behavior
Every section collapses upon selection of a new section. Selecting sub-sections produces no collapsing behavior.

Screenshots
Image

Software (please complete the following information):

  • Bazarr: 1.5.1
  • OS: Windows 11

Additional context
Radarr and Sonarr don't seem to present this issue in their latest version as of now.

@Alegom Alegom changed the title Inconsistent section expanding and collapsing in the left panel Inconsistent section expanding and collapsing in the left panel of the browser UI Feb 5, 2025
@anderson-oki
Copy link
Collaborator

anderson-oki commented Feb 6, 2025

Like radarr and sonarr We do not navigate when clicking on the menu if it has submenu as an UX choice.

Let me think more about this one. Radarr and Sonarr always navigate to the first submenu item when clicking on the parent which may be undesired and requires an useless navigation if you want to go to a sub menu that is not the first one.

Lets say you want go to system > tasks on sonarr, you always need to load useless data from system > status which i decided to dont.

Does this makes sense @Alegom?

@Alegom
Copy link
Author

Alegom commented Feb 6, 2025

@anderson-oki, I definitely see your point with avoiding loading unncessary data. That being said, UX gets a bit messy when these navigation actions get convoluted and it doesn't feel predictable for the user. With Radarr and Sonarr, I felt at least a smoother experience in navigation, but I don't like that an assumption was made as to where I wanted to go beforehand (the loading of the first page you mentioned).

With that in mind, I see two options. The first is that navigation gets decoupled from the menu collapsing / expanding actions, meaning you only truly navigate when you choose a sub-menu. The drawback is that until you do that the page on the right is not directly connected with the current status of the menu, which can be fine. The second option would be to enter a blank or index page when clicking a different menu that has sub-menus, so that an assumption is not made and therefore useless data is not loaded. I personally would prefer the former, but this is subjective of course. What do you think about it?

@anderson-oki
Copy link
Collaborator

anderson-oki commented Feb 6, 2025

The first is that navigation gets decoupled from the menu collapsing / expanding actions, meaning you only truly navigate when you choose a sub-menu.

That's exactly what i opted in and We already do that right now. The thing is, i didn't want to collapse the selected menu the user current is since it is highlighted and indicate where you are, this is extremely useful in mobile because its a full screen menu when you open the burger.

Image

In this example we highlight that we are in the Blacklist Page.

@Alegom
Copy link
Author

Alegom commented Feb 8, 2025

I understand your approach not to collapse the menus when choosing different entries, having the mobile version in mind. Since it's then a design choice and it seems to be working the way you intended, this is not a bug despite not being my personal preference. We can close this issue.

@Alegom Alegom closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants