Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install-tesptlan-ui fails #283

Closed
ryan-collingham opened this issue Sep 19, 2019 · 2 comments
Closed

install-tesptlan-ui fails #283

ryan-collingham opened this issue Sep 19, 2019 · 2 comments

Comments

@ryan-collingham
Copy link
Contributor

In master, the install-testplan-ui script is currently failing. The build is complaining about eslint-plugin-react not being available, which was recently moved into the devDependencies. I'm not quite sure how a lint plugin is being required for the production build, but the simplest fix would be to just move it back into the main dependencies.
@ryan-collingham ryan-collingham mentioned this issue Sep 19, 2019
Merged
@ryan-collingham
Copy link
Contributor Author

Maybe we should add a check in CI to ensure that the app can be installed in production mode? Since currently our tests all install in dev mode (required for test dependencies e.g. enzyme).

@ryan-collingham
Copy link
Contributor Author

This was fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryan-collingham