-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use black to format setup.py #81
Comments
Splitting off the pyflakes part of this issue to #112 , as that is not style related, and not black related. As noted at #110 (review) , adopting black at all means also configuring flake8 to use the black line length of 88. However, trying to get the templates and black and flake8 and isort working happily together is an exercise in madness. At a minimum, this repository needs to declare one supported The quickest solution is to not solve this, and instead allow other repositories to easily ignore any generated files. i.e. moremoban/moban#296 |
My argument may be old fashioned and may not be applicable to all. I am sticking with 79 line limit because it allows me to split the screen vertically in two on a 13" screen and with relatively good font size. However, since setup.py is auto-generated, the need for anyone of us to read it become useless, but to pass flake8 is more a continuous integration problem, removing any frictions in downstream project. |
reference:
pyecharts/snapshot-phantomjs#1
setup.py changes there.
The text was updated successfully, but these errors were encountered: