New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moban_command check if it is False #104

Open

chfw opened this issue Jul 14, 2019 · 0 comments

Member

chfw commented Jul 14, 2019

https://github.com/moremoban/pypi-mobans/blob/dev/templates/travis.yml.jj2#L39

The above line would still leak moban section to downstream jobs if moban_command is None.

In other words, downstream job needs explicit 'moban_command: false' in their yaml file, which in my opinion is a burden to new starters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment