Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

transfers/inbound: include CompanyIdentification in transfer lookup #591

Open
adamdecaf opened this issue Oct 7, 2020 · 1 comment
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@adamdecaf
Copy link
Member

PayGate Version: v0.9.0-dev

What were you trying to do?

When we're matching a returned ACH file we should filter based on the CompanyIdentification field of the batch.
This value is used for a multi-tenant PayGate install and would help to mark entries as unique.

There could be situations where this changes, but Moov is running PayGate in a mode where this value never changes.

Also, in the long-term Moov views the file config value as a non-changing option as we will override this in file construction based on request information.

paygate/pkg/config/odfi.go

Lines 223 to 225 in 54cb3da

type BatchHeader struct {
CompanyIdentification string
}

The transfers repository would have to change to accept this value. I see this as acceptable as other implementations may ignore this value.

transfer, err := pc.transferRepo.LookupTransferFromReturn(amount, entry.TraceNumber, effectiveEntryDate)

What did you expect to see?

Returned ACH files should always match to their respective Transfer object.

@adamdecaf adamdecaf added the enhancement New feature or request label Oct 7, 2020
@adamdecaf
Copy link
Member Author

fyi: This came up after chatting with @waltrcox on return processing workflows

@adamdecaf adamdecaf added the bug Something isn't working label Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant