Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance "required" validator fails for 0 value(s) #128

Closed
ebisrat opened this issue Nov 4, 2022 · 0 comments · Fixed by #132
Closed

Balance "required" validator fails for 0 value(s) #128

ebisrat opened this issue Nov 4, 2022 · 0 comments · Fixed by #132
Assignees
Labels
bug Something isn't working

Comments

@ebisrat
Copy link
Contributor

ebisrat commented Nov 4, 2022

Metro2 Version: v0.5.1

What were you trying to do?

Generate a metro2 using the metro2 tool. I inputted a 0 value for the CurrentBalance on one of the base segments.

What did you expect to see?

A metro2 with a base segment and 0 current balance.

What did you see?

An error stating "current_balance in base segment is a required field"

How can we reproduce the problem?
Input a 0 current balance on one of the base segments and try to generate a metro2.

Note I created a similar ticket a couple of weeks ago here. I believe the issue this time is coming from this: https://github.com/moov-io/metro2/blob/master/pkg/client/model_base_segment.go#L40, when it converts the lib model into the client model and expects a non-zero value.

@adamdecaf adamdecaf added the bug Something isn't working label Nov 15, 2022
@mfdeveloper508 mfdeveloper508 self-assigned this Nov 29, 2022
@mfdeveloper508 mfdeveloper508 linked a pull request Nov 29, 2022 that will close this issue
@mfdeveloper508 mfdeveloper508 linked a pull request Nov 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants