Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Accept changes" dialog missing when doing refinement #440

Open
Koldstream opened this issue Nov 28, 2024 · 3 comments
Open

"Accept changes" dialog missing when doing refinement #440

Koldstream opened this issue Nov 28, 2024 · 3 comments

Comments

@Koldstream
Copy link

Moorhen version: 1.13+

Issue: I noticed that the "Accept changes" dialog does not appear when doing a selection and refinement. But it will appear for atom dragging etc. This is sometimes a bit annoying as undoing doesn't always return you to exactly the same point afterwards. Has it been intentionally removed?

Cheers,
G

@stuartjamesmcnicholas
Copy link
Contributor

Not intentionally removed. I will investigate.

@FilomenoSanchez
Copy link
Member

Hi @stuartjamesmcnicholas and @Koldstream, this was never a feature so it was not removed. It would require holding the changes in a separate molecule and then only merging when the user accepts the changes. I think we could implement this without many changes.

@Koldstream
Copy link
Author

Ah okay, it might of been a miss understanding of the nanobody tutorial instructions where it says to accept them. At Icknield I think a few people were confused by that. Especially as undoing the refinement wouldn't always revert back to exactly how it was before.

It seems the undo does revert back properly in 0.14, so if that wasn't a feature in the first place I think this issue can be closed : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants