Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto removes comments when it modifies TOML files #424

Open
Phault opened this issue Mar 3, 2024 · 1 comment
Open

Proto removes comments when it modifies TOML files #424

Phault opened this issue Mar 3, 2024 · 1 comment
Assignees
@milesj
Labels
bug Something isn't working

Comments

@Phault
Copy link
Contributor

Phault commented Mar 3, 2024

What version?

0.31.1

Which command?

proto pin

What happened?

If you use comments in your .prototools, then after pinning a version using proto pin or adding a plugin with proto plugin add the comments are gone. This defeats one of the niceties of using TOML. :(

Trace logs?

No response

Operating system?

MacOS

Architecture?

arm64
@Phault Phault added the bug Something isn't working label Mar 3, 2024
@milesj
Copy link
Contributor

milesj commented Mar 3, 2024 •
edited
Loading

Yeah it's on the roadmap. I need to switch over to toml_edit on the rust side. The big problem is that we lose all type safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milesj milesj

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@milesj @Phault