Skip to content

Add inbound queue#4

Merged
ParthDesai merged 8 commits into
tanssi-polkadot-stable2407from
add-inbound-queue
Nov 15, 2024
Merged

Add inbound queue#4
ParthDesai merged 8 commits into
tanssi-polkadot-stable2407from
add-inbound-queue

Conversation

@ParthDesai
Copy link
Copy Markdown

No description provided.

Comment thread bridges/snowbridge/pallets/inbound-queue/src/xcm_message_processor.rs Outdated
Comment thread bridges/snowbridge/pallets/inbound-queue/src/lib.rs
use snowbridge_router_primitives::inbound::{MessageProcessor, VersionedXcmMessage};
use sp_runtime::DispatchError;

pub struct XcmMessageProcessor<T>(PhantomData<T>);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably call it some other thing but it is likely that snowbridge will tell you how to name it. So for me this is good enough

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason why I named it XcmMessageProcessor as it expects incoming message to be converted to xcm. :) But, let's see what snowbridge thinks.

use alloy_primitives::B256;
use alloy_sol_types::{sol, SolEvent};

sol! {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this macro?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sol! macro takes an event declaration in solidity and provides helper functions and also struct to work with that event data. Like encoding/decoding etc.

Copy link
Copy Markdown

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me it looks good, but please can you investigate what sol! does?

@ParthDesai ParthDesai merged commit 4e6395c into tanssi-polkadot-stable2407 Nov 15, 2024
@ParthDesai ParthDesai deleted the add-inbound-queue branch November 15, 2024 10:21
chexware pushed a commit that referenced this pull request Nov 15, 2024
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
chexware pushed a commit that referenced this pull request Nov 23, 2024
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Dec 31, 2024
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
dimartiro pushed a commit that referenced this pull request May 6, 2025
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
dimartiro pushed a commit that referenced this pull request May 19, 2025
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Sep 17, 2025
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Sep 17, 2025
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Sep 18, 2025
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Jan 15, 2026
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Jan 15, 2026
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Jan 15, 2026
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
tmpolaczyk pushed a commit that referenced this pull request Jan 20, 2026
* modify inbound queue to support custom message processing

* passively test tuple trait implementation

* rename XCM to Xcm everywhere

* add comment explaining MessageProcessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants