Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching groups when viewing a diff leads to error about missing v1 param in url #106

Open
davidscotson opened this issue Feb 3, 2025 · 0 comments

Comments

@davidscotson
Copy link

davidscotson commented Feb 3, 2025

When viewing an ouwiki history diff in a wiki per group setup with a url like:

mod/ouwiki/diff.php?id=1248&group=77&v2=15&v1=13

You can see the group selector dropdown on the page and using it will take you to a url like:

mod/ouwiki/diff.php?id=1248&group=76

which corretly changes the group id but loses the rest of the url and present you with the error message:

A required parameter (v1) was missing

One solution would be to not show the group selector on this page. Since the group wikis are seperate and have seperate edit histories it doesn't really make sense to switch to the same diff in a different group's wiki.

Originally spotted in a moodle 4.5 site we were testing for upgrade, with plugin version 2024020100 but I can replicate the issue on a moodle 4.1 site too, with version 2022092300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant