Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version.php file doesn't match release versions #127

Open
thepurpleblob opened this issue Sep 14, 2022 · 2 comments
Open

version.php file doesn't match release versions #127

thepurpleblob opened this issue Sep 14, 2022 · 2 comments

Comments

@thepurpleblob
Copy link

The version.php file in Github hasn't been updated for two years and still shows version 3.9 (in both the 3.11 stable release and master). The downloaded version from the plugins page shows a much newer version number.

Effectively, this makes is impossible to test the master version as the version.php file says it's old code.

@thebenkahn
Copy link

I was just coming here to post this issue.

The master branch of repo is labeled as the 3.9 version contains code for the userfieldsapi that does not work in 3.10 and earlier

$plugin->version = 2020091401;
$plugin->release = '3.9 r1';
and that is what we deployed to the site. This also matches the version string (2020091401) on the zip file for 3.9 on moodle.org.

When run on 3.10 and higher it causes an exception when accessing the activity

Exception - Class 'core_user\fields' not found
[More information about this error](https://docs.moodle.org/310/en/error/moodle/generalexceptionmessage)
×Debug info:
Error code: generalexceptionmessage
×Stack trace:
line 707 of /mod/oublog/locallib.php: Error thrown
line 241 of /mod/oublog/view.php: call to oublog_get_posts()

Since the newer branches use functionality that doesn't exist in 3.9/3.10, I think an update is needed for the "requires" field accordingly.

@stopfstedt
Copy link

i'm just getting hip to this issue as well. please put the source code of the latest release under version control here. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants