Load compiled assembly in memory and delete temporary folder

Author: jgiannuzzi

Mono.TextTemplating/Mono.TextTemplating/CompiledTemplate.cs

@@ -56,10 +56,7 @@ public CompiledTemplate (ITextTemplatingEngineHost host, CompilerResults results
 
 		void Load (CompilerResults results, string fullName)
 		{
-			//results.CompiledAssembly doesn't work on .NET core, it throws a cryptic internal error
-			//use Assembly.LoadFile instead
-			var assembly = System.Reflection.Assembly.LoadFile (results.PathToAssembly);
-			Type transformType = assembly.GetType (fullName);
+			Type transformType = results.CompiledAssembly.GetType (fullName);
 			//MS Templating Engine does not look on the type itself, 
 			//it checks only that required methods are exists in the compiled type 
 			textTransformation = Activator.CreateInstance (transformType);

Mono.TextTemplating/Mono.TextTemplating/TemplatingEngine.cs

@@ -274,17 +274,19 @@ CompilerResults CompileCode (IEnumerable<string> references, TemplateSettings se
 			r.Errors.AddRange (result.Errors.Select (e => new CompilerError (e.Origin ?? "", e.Line, e.Column, e.Code, e.Message) { IsWarning = !e.IsError }).ToArray ());
 
 			if (result.Success) {
-				r.TempFiles.AddFile (args.OutputPath, true);
+				r.TempFiles.AddFile (args.OutputPath, args.Debug);
 				if (args.Debug) {
 					r.TempFiles.AddFile (Path.ChangeExtension (args.OutputPath, ".pdb"), true);
 				}
-				r.PathToAssembly = args.OutputPath;
+				// load the assembly in memory so we can fully clean our temporary folder
+				r.CompiledAssembly = Assembly.Load (File.ReadAllBytes (args.OutputPath));
 			} else if (!r.Errors.HasErrors) {
 				r.Errors.Add (new CompilerError (null, 0, 0, null, $"The compiler exited with code {result.ExitCode}"));
 			}
 
 			if (!args.Debug && !r.Errors.HasErrors) {
 				r.TempFiles.Delete ();
+				Directory.Delete (tempFolder);
 			}
 
 			return r;