Update tests for current environments

Author: mhutch

Mono.TextTemplating.Build.Tests/Mono.TextTemplating.Build.Tests.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net472;net6.0</TargetFrameworks>
+    <TargetFrameworks>net48;net6.0</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <DefaultItemExcludes>$(DefaultItemExcludes);TestCases\**</DefaultItemExcludes>
   </PropertyGroup>
@@ -19,7 +19,7 @@
     Microsoft.NET.Test.Sdk brings in a version of NuGet.Frameworks that's older than the one used by MSBuild
     and loads first, thereby breaking loading of MSBuild assemblies. Force-upgrade it.
     -->
-    <PackageReference Include="NuGet.Frameworks" Version="6.3.1" />
+    <PackageReference Include="NuGet.Frameworks" Version="6.4.0" />
     <PackageReference Include="System.Text.Json" Version="6.0.6" />
   </ItemGroup>
 

Mono.TextTemplating.Tests/ProcessingTests.cs

@@ -57,10 +57,13 @@ public async Task CSharp9Records ()
 			await gen.ProcessTemplateAsync (null, template, outputName);
 
 			CompilerError firstError = gen.Errors.OfType<CompilerError> ().FirstOrDefault ();
-#if NET5_0
-			Assert.Null (firstError);
-#else
+
+			// note: when running on netsdk we use the highest available csc regardless of runtime version,
+			// so records will always be available on our test environments
+#if NETFRAMEWORK
 			Assert.NotNull (firstError);
+#else
+			Assert.Null (firstError);
 #endif
 		}
 

Mono.TextTemplating/CompatibilitySuppressions.xml

@@ -1,11 +1,26 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Suppressions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <!-- fixes binary incompatibility between multitargeted versions -->
   <Suppression>
-    <!-- fixes binary incompatibility between multitargeted versions -->
     <DiagnosticId>CP0006</DiagnosticId>
     <Target>M:Microsoft.VisualStudio.TextTemplating.ITextTemplatingEngineHost.ProvideTemplatingAppDomain(System.String)</Target>
     <Left>lib/netstandard2.0/Mono.TextTemplating.dll</Left>
     <Right>lib/netstandard2.0/Mono.TextTemplating.dll</Right>
     <IsBaselineSuppression>true</IsBaselineSuppression>
   </Suppression>
+    <!-- VST4 compat, should not have been public, unlikely to impact users -->
+  <Suppression>
+    <DiagnosticId>CP0019</DiagnosticId>
+    <Target>M:Microsoft.VisualStudio.TextTemplating.DirectiveProcessorException.#ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)</Target>
+    <Left>lib/net472/Mono.TextTemplating.dll</Left>
+    <Right>lib/net472/Mono.TextTemplating.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0019</DiagnosticId>
+    <Target>M:Microsoft.VisualStudio.TextTemplating.DirectiveProcessorException.#ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)</Target>
+    <Left>lib/netstandard2.0/Mono.TextTemplating.dll</Left>
+    <Right>lib/netstandard2.0/Mono.TextTemplating.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
 </Suppressions>