Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6362): cache cursor deserialization options across deserialize calls #4221

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 4, 2024

Description

What is changing?

Forward-port of #4220.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fixed enableUtf8Validation option

Starting in v6.8.0 we inadvertently removed the ability to disable UTF-8 validation when deserializing BSON. Validation is normally a good thing, but it was always meant to be configurable and the recent Node.js runtime issues (v22.7.0) make this option indispensable for avoiding errors from mistakenly generated invalid UTF-8 bytes.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title feat(NODE-6309): Mark range API as stable (#4190) fix(todo-xxxxx): cache cursor deserialization options across deserialize calls (#4190) Sep 5, 2024
@baileympearson baileympearson force-pushed the fix-regress branch 3 times, most recently from a598416 to 5e9bbc2 Compare September 6, 2024 16:32
@baileympearson baileympearson changed the title fix(todo-xxxxx): cache cursor deserialization options across deserialize calls (#4190) fix(NODE-6362): cache cursor deserialization options across deserialize calls (#4190) Sep 6, 2024
@baileympearson baileympearson marked this pull request as ready for review September 9, 2024 15:41
@nbbeeken nbbeeken self-assigned this Sep 9, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 9, 2024
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick fixes

@nbbeeken nbbeeken changed the title fix(NODE-6362): cache cursor deserialization options across deserialize calls (#4190) fix(NODE-6362): cache cursor deserialization options across deserialize calls Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants