Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6085): add TS support for KMIP data key options #4128

Merged
merged 3 commits into from
Jun 4, 2024
Merged

fix(NODE-6085): add TS support for KMIP data key options #4128

merged 3 commits into from
Jun 4, 2024

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

The original KMIP implementation added runtime support for KMIP data key options, but did not add TS support. This PR adds support for the keyId and endpoint options, with delegated to be added in NODE-5853.

Demonstration of the options working as expected:

node-mongodb-native/test/integration/client-side-encryption/client_side_encryption.prose.test.js

Line 1011 in db00ac4

description: '10. kmip: no custom endpoint',

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Typescript accuracy.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

addaleax
addaleax previously approved these changes Jun 4, 2024
View reviewed changes
@nbbeeken nbbeeken self-assigned this Jun 4, 2024
nbbeeken
nbbeeken requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, lint issue

src/client-side-encryption/client_encryption.ts Show resolved Hide resolved
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 4, 2024
@nbbeeken nbbeeken merged commit f790cc1 into mongodb:main Jun 4, 2024
29 checks passed
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Merged
baileympearson added a commit to baileympearson/node-mongodb-native that referenced this pull request Jun 5, 2024
@baileympearson
fix(NODE-6085): add TS support for KMIP data key options (mongodb#4128)
129b80f
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 19, 2024
Open
@prernaadev01 prernaadev01 mentioned this pull request Jul 19, 2024
Closed
@issam-seghir issam-seghir mentioned this pull request Jul 19, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 19, 2024
Open
@lryanle lryanle mentioned this pull request Jul 19, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request Jul 19, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Jul 19, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Jul 19, 2024
Open
@lydmoon lydmoon mentioned this pull request Jul 19, 2024
Open
@mkusztal mkusztal mentioned this pull request Jul 19, 2024
Open
@brutussegun brutussegun mentioned this pull request Jul 19, 2024
Open
@akashkumar8115 akashkumar8115 mentioned this pull request Jul 20, 2024
Open
@tarun2001jawla tarun2001jawla mentioned this pull request Jul 20, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Jul 20, 2024
Merged
@afgallo afgallo mentioned this pull request Sep 28, 2024
Merged
@tomer79sagi tomer79sagi mentioned this pull request Sep 28, 2024
Open
@aretexit aretexit mentioned this pull request Sep 28, 2024
Open
@mar4r8k-femi mar4r8k-femi mentioned this pull request Sep 28, 2024
Open
This was referenced Sep 28, 2024
Merged
Merged
Merged
Merged
Merged
@sunil-lakshman sunil-lakshman mentioned this pull request Sep 28, 2024
Open
This was referenced Sep 28, 2024
Merged
Merged
Merged
Merged
@unguest unguest mentioned this pull request Sep 28, 2024
Open
@skanda890 skanda890 mentioned this pull request Sep 29, 2024
Merged
@WontonSam WontonSam mentioned this pull request Sep 29, 2024
Open
@mkusztal mkusztal mentioned this pull request Sep 29, 2024
Open
@aravindbuilt aravindbuilt mentioned this pull request Oct 4, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Oct 4, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 4, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 4, 2024
Open
@lryanle lryanle mentioned this pull request Oct 4, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 4, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Oct 4, 2024
Open
@visrut-at-incubyte visrut-at-incubyte mentioned this pull request Oct 4, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Oct 4, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
@mkusztal mkusztal mentioned this pull request Oct 5, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@addaleax addaleax addaleax left review comments

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @addaleax @nbbeeken