-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5825): add minRoundTripTime
to ServerDescription
and change roundTripTime
to a moving average
#4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Mar 29, 2024
W-A-James
force-pushed
the
NODE-5825/add-minRTT-to-Monitor
branch
from
March 29, 2024 19:47
87e84e7
to
63d7b52
Compare
W-A-James
commented
Mar 29, 2024
W-A-James
commented
Apr 1, 2024
W-A-James
commented
Apr 1, 2024
W-A-James
commented
Apr 1, 2024
nbbeeken
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Apr 1, 2024
nbbeeken
requested changes
Apr 1, 2024
This was referenced Sep 6, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Monitor changes
rttSamplesMS
internal fieldroundTripTime
getterlatestRTT
getteraddRttSample
methodclearRttSamples
method and call inresetMonitorState
RTTSampler
class to implement spec-defined minimum and average RTT calculationsRTTPinger
changesmonitor
field to reference parentMonitor
latestRTT
field, initialized to the the monitor'slatestRTT
valuemeasureAndReschedule
to use fewer closures and clarify control flowServerDescription
changesminRoundTripTime
fieldroundTripTime
field#####Connection
changes- Addmonitor
field toconnection
to facilitate plumbing of minRoundTrip time to connection layerIs there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
ServerDescription
Round Trip Time (RTT) measurement changesServerDescription.roundTripTime
is now a moving averagePreviously,
ServerDescription.roundTripTime
was calculated as a weighted average of the most recently observed heartbeat duration and the previous duration. This update changes this behaviour to averageServerDescription.roundTripTime
over the last 10 observed heartbeats. This should reduce the likelihood that the selected server changes as a result of momentary spikes in server latency.Added
minRoundTripTime
toServerDescription
A new
minRoundTripTime
property is now available on theServerDescription
class which gives the minimum rtt over the last 10 heartbeats. Note that this value will be reported as 0 when fewer than 2 samples have been obvserved.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript