feat: reintroduce clone and rewind for cursors #2647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reintroduces support for rewinding a cursor to its uninitialized state. NODE-2811
mbroadst
force-pushed
the
NODE-2811/rewind-clone-support
branch
from
91e2ece to
df0b77e
Compare
emadum
approved these changes
Dec 2, 2020
src/cursor/find_cursor.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Returns a new unitialized copy of this cursor, with options matching those that have been set on the current instance |
Contributor
There was a problem hiding this comment.
Suggested change
| * Returns a new unitialized copy of this cursor, with options matching those that have been set on the current instance | |
| * Returns a new uninitialized copy of this cursor, with options matching those that have been set on the current instance |
Member
Author
There was a problem hiding this comment.
fixed here and in aggregation_cursor too!
mbroadst
force-pushed
the
NODE-2811/rewind-clone-support
branch
from
df0b77e to
59c5de2
Compare
nbbeeken
approved these changes
Dec 2, 2020
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
LGTM one suggestion
If we do want the abstract clone I think it's still available to us:
mbroadst
force-pushed
the
NODE-2811/rewind-clone-support
branch
from
59c5de2 to
7bbc569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These two commits add back support for cloning and rewinding cursors.
What changed?
The changes should be fairly straightforward, but I wanted to call out a few design decisions:
- I had originally intendedcloneto be an abstract method onAbstractCursor, forcing us to implement it for all possible cursor subclasses. This would have unfortunately required us to makeAbstractCursorgeneric over the subclass types, since the following signature results in type ambiguity at the point of implementation in the subclass:abstract clone(): thisTherefore,
cloneis implemented by hand inAbstractCursorsubclasses. I only implemented it forFindCursorandAggregateCursorbecause it's likely that's where legacy users have actually used this feature.There is a correction in the
rewindimplementation regarding sessions. When a session is started as part of cursor initialization I had originally marked this as anexplicit: truestart, however, this is clearly an implicit session the driver is creating in the absence of an explicitly provided one.Are there any files to ignore?
none