IMDS Mock Server Testing#1108
Merged
vector-of-bool merged 7 commits intomongodb:masterfrom Sep 28, 2022
Merged
Conversation
kevinAlbs
reviewed
Sep 28, 2022
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
I am not familiar with ctest fixtures. I left some questions, but this looks good overall.
I encountered an unexplained error running locally, and left a comment with the traceback.
build/cmake/LoadTests.cmake
Outdated
| # Split lines on newlines | ||
| string (REPLACE "\n" ";" lines "${tests_out}") | ||
|
|
||
| # XXX: Allow individual test cases to specify the fixtures they want. |
Collaborator
There was a problem hiding this comment.
What does the XXX mean?
Contributor
Author
There was a problem hiding this comment.
I've use this convention as a weaker form of "TODO". Some editors will mark it as such an annotation. I'm fine to change it, since it isn't obvious what it means.
Collaborator
There was a problem hiding this comment.
TODO, or another alternative may be preferable. This is the first I have seen of XXX.
kevinAlbs
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1104. This changeset introduces automated testing of the IMDS server via CTest test fixtures. CTest will handle spawning and stopping the IMDS server as it is needed for executing tests. The
fake_azure.pyscript was cleaned up for older Python compatibility in anticipation of sharing with other driver codebases and other platforms.