[LG-2957] feat: GuideCue - Update Button Focus #3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2ea15e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +1.51 kB (+0.08%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
adamrasheed
requested review from
a team,
TheSonOfThomp and
Copilot
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GuideCue component to set initial focus on the primary button instead of relying on default focus behavior, improving user experience when the tooltip opens.
- Replaced
useIdAllocatorhook withuseRefto reference the primary button for focus targeting - Refactored style functions to use helper methods instead of inline style composition
- Fixed spelling errors in comments ("multip-step" → "multi-step", "automically" → "automatically", "cloese" → "close")
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/guide-cue/src/GuideCueTooltip/GuideCueTooltip.tsx | Updated focus trap to target primary button using ref instead of ID-based approach; refactored style composition to use helper functions |
| packages/guide-cue/src/GuideCueTooltip/GuideCueTooltip.styles.ts | Created getCloseButtonStyle and getTooltipStyles helper functions; made internal styles private |
| packages/guide-cue/src/GuideCue/GuideCue.tsx | Fixed spelling errors in comments |
| packages/guide-cue/src/GuideCue/GuideCue.spec.tsx | Added tests to verify primary button is focusable for both standalone and multi-step tooltips |
| .changeset/real-lamps-teach.md | Added changeset for patch release |
Collaborator
TheSonOfThomp
left a comment
TheSonOfThomp
left a comment
There was a problem hiding this comment.
Imo we should update the tests to actually test focus (e.g. expect(primaryButton).toHaveFocus())
adamrasheed
requested review from
stephl3 and
tsck
and removed request for
a team
TheSonOfThomp
approved these changes
Nov 17, 2025
Contributor
|
Coverage after merging ar/LG-2957-close-button into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
TheSonOfThomp
added a commit
that referenced
this pull request
Nov 20, 2025
commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]>
TheSonOfThomp
added a commit
that referenced
this pull request
Nov 20, 2025
commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]> Squashed commit of the following: commit b1e22ce Merge: 84e889e ee58160 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 16:17:28 2025 -0500 Merge branch 'main' into at/canvas-header commit 84e889e Author: Adam Thompson <[email protected]> Date: Thu Nov 20 15:27:47 2025 -0500 Update .changeset/canvas-header.md Co-authored-by: Stephen Lee <[email protected]> commit 01049b2 Author: Adam Michael Thompson <[email protected]> Date: Thu Nov 20 15:24:22 2025 -0500 Update tsconfig.json commit ee58160 Author: Nima Taheri <[email protected]> Date: Thu Nov 20 11:55:41 2025 -0800 CLOUDP-352308 Enhanced CLI options for robust linking (#3311) * feat: update CLI options for improved linking process * docs: add changelog * docs: apply review feedback * apply: review comments + docs update * apply: review comments (2) commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]>
TheSonOfThomp
added a commit
that referenced
this pull request
Nov 21, 2025
commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]> Squashed commit of the following: commit b1e22ce Merge: 84e889e ee58160 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 16:17:28 2025 -0500 Merge branch 'main' into at/canvas-header commit 84e889e Author: Adam Thompson <[email protected]> Date: Thu Nov 20 15:27:47 2025 -0500 Update .changeset/canvas-header.md Co-authored-by: Stephen Lee <[email protected]> commit 01049b2 Author: Adam Michael Thompson <[email protected]> Date: Thu Nov 20 15:24:22 2025 -0500 Update tsconfig.json commit ee58160 Author: Nima Taheri <[email protected]> Date: Thu Nov 20 11:55:41 2025 -0800 CLOUDP-352308 Enhanced CLI options for robust linking (#3311) * feat: update CLI options for improved linking process * docs: add changelog * docs: apply review feedback * apply: review comments + docs update * apply: review comments (2) commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]>
adamrasheed
added a commit
that referenced
this pull request
Dec 4, 2025
* [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Summary
Updates the
GuideCueTooltipto focus on the primary action button instead of the close button when the tooltip opens, improving keyboard navigation and accessibility.Changes
GuideCueTooltipto usefocus-trap-react'sinitialFocusoption to target the primary buttondocument.getElementByIdfor better React practicesMotivation
Previously, when the GuideCueTooltip opened, focus would automatically go to the first focusable element (the close button). This created a suboptimal user experience as users typically want to proceed with the primary action. By focusing the primary button first, we provide better keyboard navigation and align with common UX patterns where the primary action receives initial focus.
Testing
Technical Details
useRefhook to maintain a reference to the primary buttonfocus-trap-react'sinitialFocusoption as a function that returns the button elementuseIdAllocatorusage since the button no longer needs an ID attribute🎟 Jira ticket: Change order of close button
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes