Skip to content

Commit 4f024b1

Browse files
TheSonOfThompTheSonOfThomp
committed
fixes tests
1 parent f919ecc commit 4f024b1

File tree

3 files changed

+85
-87
lines changed

3 files changed

+85
-87
lines changed

‎packages/wizard/src/WizardFooter/WizardFooter.spec.tsx‎

Lines changed: 82 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -76,101 +76,101 @@ describe('packages/wizard-footer', () => {
7676
expect(onStepChange).toHaveBeenCalledWith(1);
7777
expect(getByTestId('step-2')).toBeInTheDocument();
7878
});
79-
});
80-
81-
describe('requiresAcknowledgement', () => {
82-
test('primary button is disabled when step requires acknowledgement and is not acknowledged', () => {
83-
const { getByRole } = render(
84-
<Wizard>
85-
<Wizard.Step requiresAcknowledgement>
86-
<div>Step content</div>
87-
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
88-
</Wizard.Step>
89-
</Wizard>,
90-
);
91-
92-
const primaryButton = getByRole('button', { name: 'Continue' });
93-
expect(primaryButton).toHaveAttribute('aria-disabled', 'true');
94-
});
9579

96-
test('primary button is enabled when step requires acknowledgement and is acknowledged', async () => {
97-
const TestComponent = () => {
98-
const { setAcknowledged } = useWizardStepContext();
99-
return (
100-
<>
101-
<div>Step content</div>
102-
<button onClick={() => setAcknowledged(true)}>Acknowledge</button>
103-
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
104-
</>
80+
describe('requiresAcknowledgement', () => {
81+
test('primary button is disabled when step requires acknowledgement and is not acknowledged', () => {
82+
const { getByRole } = render(
83+
<Wizard>
84+
<Wizard.Step requiresAcknowledgement>
85+
<div>Step content</div>
86+
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
87+
</Wizard.Step>
88+
</Wizard>,
10589
);
106-
};
10790

108-
const { getByRole } = render(
109-
<Wizard>
110-
<Wizard.Step requiresAcknowledgement>
111-
<TestComponent />
112-
</Wizard.Step>
113-
</Wizard>,
114-
);
91+
const primaryButton = getByRole('button', { name: 'Continue' });
92+
expect(primaryButton).toHaveAttribute('aria-disabled', 'true');
93+
});
94+
95+
test('primary button is enabled when step requires acknowledgement and is acknowledged', async () => {
96+
const TestComponent = () => {
97+
const { setAcknowledged } = useWizardStepContext();
98+
return (
99+
<>
100+
<div>Step content</div>
101+
<button onClick={() => setAcknowledged(true)}>Acknowledge</button>
102+
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
103+
</>
104+
);
105+
};
106+
107+
const { getByRole } = render(
108+
<Wizard>
109+
<Wizard.Step requiresAcknowledgement>
110+
<TestComponent />
111+
</Wizard.Step>
112+
</Wizard>,
113+
);
115114

116-
const primaryButton = getByRole('button', { name: 'Continue' });
117-
expect(primaryButton).toHaveAttribute('aria-disabled', 'true');
115+
const primaryButton = getByRole('button', { name: 'Continue' });
116+
expect(primaryButton).toHaveAttribute('aria-disabled', 'true');
118117

119-
await userEvent.click(getByRole('button', { name: 'Acknowledge' }));
118+
await userEvent.click(getByRole('button', { name: 'Acknowledge' }));
120119

121-
expect(primaryButton).toHaveAttribute('aria-disabled', 'false');
122-
});
120+
expect(primaryButton).toHaveAttribute('aria-disabled', 'false');
121+
});
123122

124-
test('primary button is enabled when step does not require acknowledgement', () => {
125-
const { getByRole } = render(
126-
<Wizard>
127-
<Wizard.Step>
128-
<div>Step content</div>
129-
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
130-
</Wizard.Step>
131-
</Wizard>,
132-
);
133-
134-
const primaryButton = getByRole('button', { name: 'Continue' });
135-
expect(primaryButton).toHaveAttribute('aria-disabled', 'false');
136-
});
137-
138-
test('primary button can advance step after acknowledgement', async () => {
139-
const TestComponent = () => {
140-
const { setAcknowledged } = useWizardStepContext();
141-
return (
142-
<>
143-
<div>Step content</div>
144-
<button onClick={() => setAcknowledged(true)}>Acknowledge</button>
145-
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
146-
</>
123+
test('primary button is enabled when step does not require acknowledgement', () => {
124+
const { getByRole } = render(
125+
<Wizard>
126+
<Wizard.Step>
127+
<div>Step content</div>
128+
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
129+
</Wizard.Step>
130+
</Wizard>,
147131
);
148-
};
149132

150-
const { getByRole, getByTestId } = render(
151-
<Wizard>
152-
<Wizard.Step requiresAcknowledgement>
153-
<div data-testid="step-1">Step 1</div>
154-
<TestComponent />
155-
</Wizard.Step>
156-
<Wizard.Step>
157-
<div data-testid="step-2">Step 2</div>
158-
</Wizard.Step>
159-
</Wizard>,
160-
);
133+
const primaryButton = getByRole('button', { name: 'Continue' });
134+
expect(primaryButton).toHaveAttribute('aria-disabled', 'false');
135+
});
136+
137+
test('primary button can advance step after acknowledgement', async () => {
138+
const TestComponent = () => {
139+
const { setAcknowledged } = useWizardStepContext();
140+
return (
141+
<>
142+
<div>Step content</div>
143+
<button onClick={() => setAcknowledged(true)}>Acknowledge</button>
144+
<Wizard.Footer primaryButtonProps={{ children: 'Continue' }} />
145+
</>
146+
);
147+
};
148+
149+
const { getByRole, getByTestId } = render(
150+
<Wizard>
151+
<Wizard.Step requiresAcknowledgement>
152+
<div data-testid="step-1">Step 1</div>
153+
<TestComponent />
154+
</Wizard.Step>
155+
<Wizard.Step>
156+
<div data-testid="step-2">Step 2</div>
157+
</Wizard.Step>
158+
</Wizard>,
159+
);
161160

162-
expect(getByTestId('step-1')).toBeInTheDocument();
161+
expect(getByTestId('step-1')).toBeInTheDocument();
163162

164-
const primaryButton = getByRole('button', { name: 'Continue' });
165-
expect(primaryButton).toHaveAttribute('aria-disabled', 'true');
163+
const primaryButton = getByRole('button', { name: 'Continue' });
164+
expect(primaryButton).toHaveAttribute('aria-disabled', 'true');
166165

167-
// Acknowledge the step
168-
await userEvent.click(getByRole('button', { name: 'Acknowledge' }));
169-
expect(primaryButton).toHaveAttribute('aria-disabled', 'false');
166+
// Acknowledge the step
167+
await userEvent.click(getByRole('button', { name: 'Acknowledge' }));
168+
expect(primaryButton).toHaveAttribute('aria-disabled', 'false');
170169

171-
// Advance to next step
172-
await userEvent.click(primaryButton);
173-
expect(getByTestId('step-2')).toBeInTheDocument();
170+
// Advance to next step
171+
await userEvent.click(primaryButton);
172+
expect(getByTestId('step-2')).toBeInTheDocument();
173+
});
174174
});
175175
});
176176

‎packages/wizard/src/WizardFooter/WizardFooter.types.ts‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ import type {
55
PrimaryStandardButtonProps,
66
} from '@leafygreen-ui/form-footer';
77

8-
export interface WizardFooterProps
9-
extends React.ComponentProps<'footer'>,
10-
FormFooterProps {
8+
export interface WizardFooterProps extends FormFooterProps {
119
backButtonProps?: BackStandardButtonProps;
1210
cancelButtonProps?: CancelStandardButtonProps;
1311
primaryButtonProps: PrimaryStandardButtonProps;

‎packages/wizard/src/WizardStep/WizardStep.spec.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('packages/wizard-step', () => {
2828
});
2929

3030
describe('requiresAcknowledgement', () => {
31-
test('when false, does not require acknowledgement', () => {
31+
test('by default, does not require acknowledgement', () => {
3232
const TestComponent = () => {
3333
const { requiresAcknowledgement } = useWizardStepContext();
3434
return (
@@ -70,7 +70,7 @@ describe('packages/wizard-step', () => {
7070
expect(getByTestId('requires-ack')).toHaveTextContent('true');
7171
});
7272

73-
test('isAcknowledged starts as false', () => {
73+
test('isAcknowledged is false by default', () => {
7474
const TestComponent = () => {
7575
const { isAcknowledged } = useWizardStepContext();
7676
return <div data-testid="is-ack">{String(isAcknowledged)}</div>;

0 commit comments

Comments
 (0)