feat(NODE-4711)!: remove evalFunctions option #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
the
Primary Review
durran
requested changes
Dec 8, 2022
durran
previously approved these changes
Dec 8, 2022
durran
added
Team Review
durran
force-pushed
the
NODE-4711-rm-eval
branch
from
2562947
to
390642e
Compare
durran
previously approved these changes
Dec 9, 2022
addaleax
reviewed
Dec 9, 2022
nbbeeken
changed the title
addaleax
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
evalFunctionsoption and friends are removedserializeFunctionsoptionWhat is the motivation for this change?
Evaluating javascript strings is not a common practice and since the BSON code type is generally used for legacy operations (pre aggregation pipeline) it generally not javascript that would be useful to be invoked client side.
There is a migration example if this feature is still desired.
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>