few cleanups

Author: timgraham

django_mongodb/fields/array.py

@@ -68,7 +68,7 @@ def check(self, **kwargs):
                 checks.Error(
                     "Base field for array cannot be a related field.",
                     obj=self,
-                    id="postgres.E002",
+                    id="django_mongodb.array.E002",
                 )
             )
         else:
@@ -85,7 +85,7 @@ def check(self, **kwargs):
                         checks.Error(
                             f"Base field for array has errors:\n    {error_messages}",
                             obj=self,
-                            id="postgres.E001",
+                            id="django_mongodb.array.E001",
                         )
                     )
                 warning_messages = "\n    ".join(
@@ -98,7 +98,7 @@ def check(self, **kwargs):
                         checks.Warning(
                             f"Base field for array has warnings:\n    {warning_messages}",
                             obj=self,
-                            id="postgres.W004",
+                            id="django_mongodb.array.W004",
                         )
                     )
         return errors
@@ -112,14 +112,8 @@ def description(self):
         return f"Array of {self.base_field.description}"
 
     def db_type(self, connection):
-        # size = self.size or ""
-        # return "%s[%s]" % (self.base_field.db_type(connection), size)
         return "array"
 
-    # def cast_db_type(self, connection):
-    #     size = self.size or ""
-    #     return "%s[%s]" % (self.base_field.cast_db_type(connection), size)
-
     def db_parameters(self, connection):
         db_params = super().db_parameters(connection)
         db_params["collation"] = self.db_collation

tests/model_fields_/test_arrayfield.py

@@ -335,7 +335,6 @@ def test_contains_including_expression(self):
         )
 
     def test_icontains(self):
-        # Using the __icontains lookup with ArrayField is inefficient.
         instance = CharArrayModel.objects.create(field=["FoO"])
         self.assertSequenceEqual(CharArrayModel.objects.filter(field__icontains="foo"), [instance])
 
@@ -518,7 +517,7 @@ class MyModel(models.Model):
         errors = model.check()
         self.assertEqual(len(errors), 1)
         # The inner CharField has a non-positive max_length.
-        self.assertEqual(errors[0].id, "postgres.E001")
+        self.assertEqual(errors[0].id, "django_mongodb.array.E001")
         self.assertIn("max_length", errors[0].msg)
 
     def test_invalid_base_fields(self):
@@ -528,7 +527,7 @@ class MyModel(models.Model):
         model = MyModel()
         errors = model.check()
         self.assertEqual(len(errors), 1)
-        self.assertEqual(errors[0].id, "postgres.E002")
+        self.assertEqual(errors[0].id, "django_mongodb.array.E002")
 
     def test_invalid_default(self):
         class MyModel(models.Model):
@@ -577,7 +576,7 @@ class MyModel(models.Model):
         errors = model.check()
         self.assertEqual(len(errors), 1)
         # The inner CharField has a non-positive max_length.
-        self.assertEqual(errors[0].id, "postgres.E001")
+        self.assertEqual(errors[0].id, "django_mongodb.array.E001")
         self.assertIn("max_length", errors[0].msg)
 
     def test_choices_tuple_list(self):