Skip to content

Conversation

@juliusgeo
Copy link
Contributor

No description provided.

README.rst Outdated

ExplainCollection(collection).find({}).sort(...)

it will fail.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you offer a suggested workaround? Something like:

Instead pass all the arguments to the find() call, like so::

    ExplainCollection(collection).find({}, sort=...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.rst Outdated
- the explain output will be sent to whatever stream your script configures the logging module to send output to.
- if your script sets the `logging level <https://docs.python.org/3/library/logging.html#logging-levels>`_
higher than INFO, the explain output will be suppressed entirely.
- the explain output will be sent to whatever stream your script configures the logging module to send output to.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.rst Outdated

Limitations
-----------
This package does not support the fluent `Cursor API <https://api.mongodb.com/python/current/api/pymongo/cursor.html>`_,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct link for PyMongo documentation. It should be: https://pymongo.readthedocs.io/en/stable/api/pymongo/cursor.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

==================

For questions, discussions, or general technical support, visit the MongoDB Community Forums.
For questions, discussions, or general technical support, visit the `MongoDB Community Forums <https://developer.mongodb.com/community/forums/tag/python>`_.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to this GitHub repository in the reference to 'this GitHub repository' on L48

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.



Limitations
-----------

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a blank line after the title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link

@prashantmital prashantmital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the import to ExplainableCollection.

Copy link
Collaborator

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliusgeo juliusgeo merged commit 971463a into mongodb-labs:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README improvments Add 'Limitations' section to README Update tutorial to show imports

3 participants