fix(NODE-6300): make expressionMode required in C++ in makeExplicitEncryptionContext #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
5 tasks
baileympearson
force-pushed
the
make-expressionMode-required
branch
from
8ff975a
to
c40e901
Compare
baileympearson
commented
Jul 31, 2024
| @@ -23,6 +23,7 @@ | |||
| "check:clang-format": "clang-format --style=file:.clang-format --dry-run --Werror addon/*", | |||
| "test": "mocha test", | |||
| "prepare": "tsc", | |||
| "rebuild": "node-gyp rebuild", | |||
There was a problem hiding this comment.
This isn't necessary for this PR, just nice-to-have.
baileympearson
changed the title
W-A-James
added
the
Primary Review
W-A-James
reviewed
Jul 31, 2024
W-A-James
approved these changes
Jul 31, 2024
W-A-James
added
Team Review
addaleax
approved these changes
Jul 31, 2024
aditi-khare-mongoDB
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
MakeExplicitEncryptionContext takes an option,
expressionMode, that controls whether an expression context or regular context is instantiated. This option is always provided by the driver, is required by TS but in C++ we coerce the option to boolean instead.This PR aligns the C++ to match the intended behavior.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript