chore(deps): bump mongosh to 2.5.9 COMPASS-10006 #7521
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates MongoDB-related dependencies to bump mongosh to version 2.5.9, as indicated by the title. The changes update various @mongosh/* and @mongodb-js/devtools-* packages across multiple package.json files.
- Updated mongosh-related packages (
@mongosh/browser-repl,@mongosh/logging,@mongosh/node-runtime-worker-thread) - Updated devtools packages (
@mongodb-js/devtools-connect,@mongodb-js/devtools-proxy-support)
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/data-service/package.json | Updated devtools-connect and devtools-proxy-support versions |
| packages/compass/package.json | Updated mongosh node-runtime-worker-thread and devtools-proxy-support versions |
| packages/compass-web/package.json | Updated devtools-proxy-support version |
| packages/compass-shell/package.json | Updated multiple mongosh packages (browser-repl, logging, node-runtime-worker-thread) |
| packages/compass-preferences-model/package.json | Updated devtools-proxy-support version |
| packages/atlas-service/package.json | Updated devtools-connect and devtools-proxy-support versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
Noticed that your PR updating mongosh to latest updates more things than our automated PR. Are we missing some important dependencies that should be bumped at the same time in this config here?
|
@gribnoysup Yes, a typical shell update PR should also bump devtools-connect, devtools-proxy support, the driver and its dependencies (bson, mongodb-client-encryption, etc.) to the same version used in mongosh |
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
If you have a moment to list those required mongosh deps in the auto update config, that'd be very helpful, but totally not required, I'll follow-up a bit later if you don't have bandwidth for that. Thanks again for clarifying what needs to be there
…pdate config Unfortunately, I don't think there's a way to express "when updating mongosh dependencies, bump these other dependencies to the same version used by the new mongosh dependency versions", so this will keep requiring some human attention. Refs: #7521 (review)
|
@gribnoysup Sure! #7527 |
…pdate config (#7527) Unfortunately, I don't think there's a way to express "when updating mongosh dependencies, bump these other dependencies to the same version used by the new mongosh dependency versions", so this will keep requiring some human attention. Refs: #7521 (review)
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes