Skip to content

Commit befa2e6

Browse files
authored
chore(aggregations, find-in-page, import-export, databases-collections): refactor Global.Modal to use new plugin interface COMPASS-7398 (#5081)
* chore(compass-aggregations): convert create view to new plugin format; remove duplicated plugin * chore(find-in-page): convert find in page plugin to new interface * chore(databases-collections): convert create / delete namespace modals to new plugin interface * chore(import-export): convert import-export to use new plugin interface * chore(aggregations): clean up compass:aggregations events * chore(aggregations): fix eslint
1 parent 92c3e3d commit befa2e6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+623
-1145
lines changed

package-lock.json

Lines changed: 22 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass-aggregations/README.md

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -177,22 +177,9 @@ application can be listened to via [hadron-app-registry][hadron-app-registry].
177177
- **'compass:export-to-language:opened', source**: Indicates
178178
`export-to-language` was opened. `source` refers to the module it is opened
179179
from, in this case `Aggregations`.
180-
- **'compass:aggregations:pipeline-imported'**: Indicates a pipeline ws
181-
imported, either from pasting the pipeline in, or from using the import
182-
functionality. Sends data to metrics.
183-
- **'compass:aggregations:create-view', numOfStages**: Indicates `Create View` was
184-
successful. `numOfStages` refers to pipeline length. Sends data to metrics.
185-
- **'compass:aggregations:pipeline-opened'**: Indicates a saved pipeline was
186-
opened. Sends pipeline data to metrics.
187180
- **'open-namespace-in-new-tab'**: Indicates current pipeline's namespace is to
188181
be opened in a new tab. Called when `Create View` is successful, when
189182
`$merge` are to be shown, when `$out` results are to be shown.
190-
- **'compass:aggregations:update-view', numOfStages**: Indicates a pipeline view
191-
was updated. `numOfStages` refers to the length of the pipeline. Sends data to
192-
metrics.
193-
- **'compass:aggregations:settings-applied', settings**: Indicates pipeline
194-
settings are to be applied. `settings` include: `isExpanded`, `isCommentMode`,
195-
`isDirty`, `sampleSize`, `maxTimeMS`, `limit`.
196183
- **'refresh-data'**: Indicates a data refresh is required within Compass.
197184
- **'select-namespace', metadata**: Indicates a namespace is being selected.
198185
Emitted when updating a collection. `metadata` refers to information about the
@@ -238,11 +225,6 @@ application can be listened to via [hadron-app-registry][hadron-app-registry].
238225
- `agg-pipeline-deleted`
239226
- `agg-pipeline-executed`
240227
- `agg-pipeline-out-executed`
241-
- `compass:aggregations:update-view`
242-
- `compass:aggregations:create-view`
243-
- `compass:aggregations:pipeline-opened`
244-
- `compass:aggregations:settings-applied`
245-
- `compass:aggregations:pipeline-imported`
246228

247229
## Development
248230

packages/compass-aggregations/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
"@mongodb-js/my-queries-storage": "^0.2.1",
5252
"bson": "^6.0.0",
5353
"compass-preferences-model": "^2.15.6",
54+
"hadron-app-registry": "^9.0.14",
5455
"hadron-document": "^8.4.3",
5556
"hadron-type-checker": "^7.1.0",
5657
"react": "^17.0.2"
@@ -72,12 +73,10 @@
7273
"@types/lodash": "^4.14.188",
7374
"@types/semver": "^7.3.9",
7475
"chai": "^4.3.6",
75-
"debug": "^4.2.0",
7676
"depcheck": "^1.4.1",
7777
"ejson-shell-parser": "^1.2.4",
7878
"enzyme": "^3.11.0",
7979
"eslint": "^7.25.0",
80-
"hadron-app-registry": "^9.0.14",
8180
"lodash": "^4.17.21",
8281
"mocha": "^10.2.0",
8382
"mongodb": "^6.0.0",
@@ -112,6 +111,7 @@
112111
"@mongodb-js/my-queries-storage": "^0.2.1",
113112
"bson": "^6.0.0",
114113
"compass-preferences-model": "^2.15.6",
114+
"hadron-app-registry": "^9.0.13",
115115
"hadron-document": "^8.4.3",
116116
"hadron-type-checker": "^7.1.0"
117117
},

packages/compass-aggregations/src/components/create-view-plugin.jsx

Lines changed: 0 additions & 26 deletions
This file was deleted.

packages/compass-aggregations/src/components/duplicate-view-modal/duplicate-view-modal.jsx

Lines changed: 0 additions & 133 deletions
This file was deleted.

packages/compass-aggregations/src/components/duplicate-view-modal/index.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)