Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis 4.2.0 Redis#exists Returning an integer Instead of a Boolean #189

Closed
bvicenzo opened this issue Jun 18, 2020 · 3 comments
Closed

Redis 4.2.0 Redis#exists Returning an integer Instead of a Boolean #189

bvicenzo opened this issue Jun 18, 2020 · 3 comments
Labels

Comments

@bvicenzo
Copy link

bvicenzo commented Jun 18, 2020

Hello Guys.
Since Redis gem 4.2.0 the method Redis#exists is warning that message:

`Redis#exists(key)` will return an Integer in redis-rb 4.3. `exists?` returns a boolean, you should use it instead.
To opt-in to the new behavior now you can set Redis.exists_returns_integer =  true.
To disable this message and keep the current (boolean) behaviour of 'exists'
you can set `Redis.exists_returns_integer = false`, but this option will be 
removed in 5.0. (***/gems/moneta-1.3.0/lib/moneta/adapters/redis.rb:29:in `block in key?')

Is it possible we change to method Redis#exists?(key) here as the message suggest?

@asppsa
Copy link
Collaborator

asppsa commented Jun 19, 2020

Thanks for the report - looks like switching to #exists? is the way to go.

@asppsa
Copy link
Collaborator

asppsa commented Aug 23, 2020

Closed by #192

@asppsa asppsa closed this as completed Aug 23, 2020
@asppsa
Copy link
Collaborator

asppsa commented Aug 23, 2020

Fixed in v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants