Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: convert VirtualizedList stories file to TS #2522

Open
rivka-ungar opened this issue Oct 13, 2024 · 4 comments · May be fixed by #2544 or #2545
Open

docs: convert VirtualizedList stories file to TS #2522

rivka-ungar opened this issue Oct 13, 2024 · 4 comments · May be fixed by #2544 or #2545
Assignees
@shawaiz-khan
Labels
contribution welcome documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest

Comments

@rivka-ungar
Copy link
Contributor

Convert the VirtualizedList stories file to TypeScript:

  • Change the file extension to stories.tsx
  • Resolve type issues (if there are), avoid using any and prefer existing types

Related files

packages/core/src/components/VirtualizedList/__stories__/VirtualizedList.stories.js

Monday ticket [internal]
@rivka-ungar rivka-ungar added documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest contribution welcome labels Oct 13, 2024
@vladboisa vladboisa mentioned this issue Oct 13, 2024
Open
1 task
@shawaiz-khan
Copy link
Contributor

Can I work on this?

@mSaurabh
Copy link

@rivka-ungar If no one is working on this, please assign it to me.

@talkor
Copy link
Member

talkor commented Oct 16, 2024 •
edited
Loading

Thanks @shawaiz-khan @mSaurabh, see mentioned PR in this issue, it's currently handled

@vladboisa
Copy link

vladboisa commented Oct 16, 2024 •
edited
Loading

Thanks @shawaiz-khan @mSaurabh, see mentioned PR in this issue, it's currently handled

Sorry, my fault, that referenced #2522 by mistake, it should be #2516, already fixed in PR.

@vladboisa vladboisa linked a pull request Oct 16, 2024 that will close this issue
Open
1 task
@shawaiz-khan shawaiz-khan linked a pull request Oct 16, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawaiz-khan shawaiz-khan

Labels
contribution welcome documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
5 participants
@mSaurabh @talkor @rivka-ungar @vladboisa @shawaiz-khan