Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MenuItem): tooltip should on all item and not only on title #1914

Conversation

YossiSaadi
Copy link
Contributor

@YossiSaadi YossiSaadi commented Jan 23, 2024

this is a temp hack until the next major, it adds a hidden title element, not visible to screen readers and keyboard navigation, but it catches hover for tooltip width

https://monday.monday.com/boards/3532714909/pulses/5910955456

@YossiSaadi YossiSaadi requested a review from a team as a code owner January 23, 2024 13:57
for MenuItem's hiddenTitle to have the correct width limits
@YossiSaadi YossiSaadi marked this pull request as draft January 23, 2024 15:54
@talkor talkor marked this pull request as ready for review January 28, 2024 19:22
@talkor talkor merged commit 5151bde into master Jan 29, 2024
11 checks passed
@talkor talkor deleted the fix/yossi/MenuItem---tooltip-should-wrap-all-the-item-not-only-title-5910955456 branch January 29, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants